[Messenger][AmazonSQS] Add AddFifoStamp middleware
#19055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Oct 20, 2023
messenger.rst
Outdated
| @@ -1810,6 +1810,17 @@ The transport has a number of options: | |||
| If the queue name is suffixed by ``.fifo``, AWS will create a `FIFO queue`_. | |||
| Use the stamp :class:`Symfony\\Component\\Messenger\\Bridge\\AmazonSqs\\Transport\\AmazonSqsFifoStamp` | |||
| to define the ``Message group ID`` and the ``Message deduplication ID``. | |||
| You can also enable the | |||
There was a problem hiding this comment.
- This is only useful when using AWS
- We should explain more what it does internally, when using it
There was a problem hiding this comment.
This bit has been added to the SQS part, so I guess your first point is resolved 🙂
I also reworded to be more precise on what this middleware does internally. I missed the two new interfaces. Thanks!
alexandre-daubois
force-pushed
the
aws-fifo-stamp
branch
from
48c13ea to
08344a4
Compare
OskarStark
changed the title
AddFifoStamp middleware
|
Thank you Alexandre. |
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19050