Skip to content

[Security] fix: propose a better header naming for custom authenticator #20107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Aug 12, 2024

@carsonbot carsonbot added this to the 5.4 milestone Aug 12, 2024
@javiereguiluz
Copy link
Member

Thanks for proposing this. I'm trying to find the auth_token HTTP header in the link that you shared but I can't find it. What am I doing wrong?

@carsonbot carsonbot changed the title fix: propose a better header naming for custom authenticator [Security] fix: propose a better header naming for custom authenticator Aug 26, 2024
@94noni
Copy link
Contributor Author

94noni commented Aug 26, 2024

@javiereguiluz its only the 2nd paragraph, the goal is to remove the x-

Custom proprietary headers have historically been used with an X- prefix,
but this convention was deprecated in June 2012 because of the inconveniences it caused when nonstandard fields became standard in [RFC 6648](https://datatracker.ietf.org/doc/html/rfc6648); 
others are listed in the [IANA HTTP Field Name Registry](https://www.iana.org/assignments/http-fields/http-fields.xhtml), whose original content was defined in [RFC 4229](https://datatracker.ietf.org/doc/html/rfc4229). The IANA registry lists headers, including [information about their status](https://github.com/protocol-registries/http-fields?tab=readme-ov-file#choosing-the-right-status), which may be "permanent" (standards-defined), "provisional" (new), "deprecated" (use not recommended), or "obsolete" (no longer in use).

@javiereguiluz javiereguiluz merged commit 24ed0c0 into symfony:5.4 Aug 26, 2024
3 checks passed
@javiereguiluz
Copy link
Member

OK, now I understand. Thanks Antoine.

While merging I added a comment (see 1666a1c) to avoid any confusion and be very explicit about this just being a random example of a custom HTTP header.

@94noni 94noni deleted the patch-10 branch August 26, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants