Skip to content

[Console] Add markdown format to Table #20654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Console] Add markdown format to Table #20654

wants to merge 2 commits into from

Conversation

amenk
Copy link
Contributor

@amenk amenk commented Feb 14, 2025

Closes #20653

@carsonbot carsonbot added this to the 7.3 milestone Feb 14, 2025
@carsonbot
Copy link
Collaborator

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

welcoMattic
welcoMattic reviewed Feb 14, 2025
View reviewed changes
components/console/helpers/table.rst
$table->setStyle('markdown');
$table->render();

This outputs the table in the Markdown format:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This outputs the table in the Markdown format:
The output of this command will be:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to put some emphasis on that it supports Markdown format ... what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think it's not a bad idea to emphasize this, so I merged it "as is". Thanks.

javiereguiluz added a commit that referenced this pull request Feb 17, 2025
@javiereguiluz
minor #20654 [Console] Add markdown format to Table (amenk)
889849c 
This PR was squashed before being merged into the 7.3 branch.

Discussion
----------

[Console] Add markdown format to Table

Closes #20653

Commits
-------

2f95737 [Console] Add markdown format to Table
@javiereguiluz
Copy link
Member

Alexander, thanks for updating the docs ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz
Copy link
Member

Closing manually because our merging tool didn't close this automatically. This was merged in 889849c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@welcoMattic welcoMattic welcoMattic left review comments

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[Console] Add markdown format to Table
4 participants
@amenk @carsonbot @javiereguiluz @welcoMattic