Skip to content

[DomCrawler] each() iterates over items as Crawlers #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

julien-c
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to 2.3
Fixed tickets #2568

@wouterj
Copy link
Member

wouterj commented May 14, 2013

Could you please also fix the other things mentioned in #2568 ? And add the pull request format to the pr description?

@julien-c
Copy link
Contributor Author

@wouterj PR format added. For the reduce function, there's nothing to do AFAICT, unless you want me to make the example more complex?

@wouterj
Copy link
Member

wouterj commented May 14, 2013

you're right actually, I never did a good look into that example. I'm 👍 for this, thank you for working on it!

@wouterj
Copy link
Member

wouterj commented May 14, 2013

One thing though: We can/should add a vesionadded directive mentioning the change. Something like:

.. versionadded:: 2.3
    The node argument is a ``Crawler`` instance as of Symfony 2.3.
    In prior versions, it was a ``DOMElement`` instance.

@julien-c
Copy link
Contributor Author

Do you want me to do it?

@wouterj
Copy link
Member

wouterj commented May 14, 2013

If you can do it: Yes! Otherwise I'll create a PR

@xabbuh
Copy link
Member

xabbuh commented Jun 4, 2013

Any news on this topic?

weaverryan added a commit that referenced this pull request Jun 30, 2013
@weaverryan
Copy link
Member

Hi Julien!

Thanks for the nice PR here! I've patched this into the 2.3 branch at sha: ed0920e. You'll notice that some of the changes are missing, only because they have already been done in other PR's. I also added the versionadded and a type-hint at sha: a15a9d5

Thanks!

@weaverryan weaverryan closed this Jun 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants