Skip to content

Clarifying usage of delivery_whitelist #8575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Clarifying usage of delivery_whitelist #8575

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff92385
Clarifying usage of delivery_whitelist
tomhv Nov 1, 2017
c572e88
Making message simpler and more concise
tomhv Nov 3, 2017
55aec20
Adding missing backticks
tomhv Nov 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions email/dev_environment.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,10 @@ In the above example all email messages will be redirected to ``[email protected]`
and messages sent to the ``[email protected]`` address or to any email address
belonging to the domain ``specialdomain.com`` will also be delivered as normal.

.. caution::

The ``delivery_whitelist`` option can only be used in conjuction with the ``delivery_addresses`` option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: conjunction

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reword this to make it easier to read? Something like this:

The ``delivery_whitelist`` option is ignored when the ``delivery_addresses``
option is not defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this:

The delivery_whitelist option is ignored unless the delivery_addresses option is defined.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and concise! I like it. Thanks!


Viewing from the Web Debug Toolbar
----------------------------------

Expand Down