Skip to content

Updated the behavior of the checkDNS option #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #8171.

)));
}
}

This option uses the :phpfunction:`checkdnsrr` PHP function to check the validity
of the ``ANY`` DNS record corresponding to the host associated with the given URL.
of DNS record corresponding to the host associated with the given URL.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of the DNS record

@@ -233,7 +233,8 @@ checkDNS

By default, this constraint just validates the syntax of the given URL. If you
also need to check whether the associated host exists, set the ``checkDNS``
option to ``true``:
option to the value of any of the ``CHECK_DNS_TYPE_*`` constants of the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constants in the class sounds better to me.

javiereguiluz added a commit that referenced this pull request Jan 29, 2018
This PR was squashed before being merged into the 3.4 branch (closes #9131).

Discussion
----------

Updated the behavior of the checkDNS option

This fixes #8171.

Commits
-------

599d556 Updated the behavior of the checkDNS option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants