Skip to content

Update web_server_configuration.rst #9596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2018
Merged

Update web_server_configuration.rst #9596

merged 1 commit into from
Apr 16, 2018

Conversation

JuanLuisGarciaBorrego
Copy link
Contributor

Replace path /var/run/php7.1-fpm.sock by /var/run/php/php7.1-fpm.sock

@javiereguiluz
Copy link
Member

Thanks for this contribution Juan Luis! I'm trying to verify these changes with some official resource but https://php-fpm.org/ seems to be abandoned. Can you please share some link that explains the rationale behind this change? Thanks!

@JuanLuisGarciaBorrego
Copy link
Contributor Author

JuanLuisGarciaBorrego commented Apr 16, 2018 •
edited by javiereguiluz
Loading

Hi @javiereguiluz

No, I do not have any official resources, but I have checked the php-fpm config where the socket is created with:

~$ cat /etc/php/7.2/fpm/pool.d/www.conf
Result listen = /run/php/php7.2-fpm.sock

~$ cat /etc/php/7.1/fpm/pool.d/www.conf
Result: listen = /run/php/php7.1-fpm.sock

The socket is saved under /var/run/php

~$ tree /var/run/php/
/var/run/php/
├── php7.*-fpm.pid
└── php7.*-fpm.sock

Greetings Javier

@javiereguiluz javiereguiluz added this to the 2.7 milestone Apr 16, 2018
@JuanLuisGarciaBorrego @javiereguiluz
Update web_server_configuration.rst
e20c490 
Replace path /var/run/php7.1-fpm.sock by /var/run/php/php7.1-fpm.sock
@javiereguiluz javiereguiluz changed the base branch from master to 2.7 April 16, 2018 14:39
@javiereguiluz
Copy link
Member

Thanks for the info! I've Googled about this a bit more and you can find lots of results for the new file paths proposed by your pull request, so let's merge it (on the 2.7 branch). Congrats on your first Symfony Docs contribution too. Thanks!

@javiereguiluz javiereguiluz merged commit e20c490 into symfony:2.7 Apr 16, 2018
javiereguiluz added a commit that referenced this pull request Apr 16, 2018
@javiereguiluz
minor #9596 Update web_server_configuration.rst (JuanLuisGarciaBorrego)
c021ae1 
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #9596).

Discussion
----------

Update web_server_configuration.rst

Replace path /var/run/php7.1-fpm.sock by /var/run/php/php7.1-fpm.sock

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

e20c490 Update web_server_configuration.rst
@JuanLuisGarciaBorrego
Copy link
Contributor Author

Great!!
Thanks you Javier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@JuanLuisGarciaBorrego @javiereguiluz @carsonbot