Revert fix factory-service new syntax #9729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
May 4, 2018
|
Thank you @lex111. |
xabbuh
added a commit
that referenced
this pull request
May 4, 2018
This PR was merged into the 2.7 branch. Discussion ---------- Revert fix factory-service new syntax This should apply **only** to branches 2.x (`2.7` and `2.8`), new versions (> 3.x) use the full class name, and therefore two colons should be used, not one Commits ------- bd43a5f Revert fix factory-service new syntax
|
FYI, the related code for parsing the factory syntax is not located in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should apply only to branches 2.x (
2.7and2.8), new versions (> 3.x) use the full class name, and therefore two colons should be used, not one