Skip to content

Commit 8d13f4b

Browse files
committed
Merge branch '6.0' into 6.1
* 6.0: Use external links instead of fake issue templates Fix description that does not work well Document deprecations in Security Tokens
2 parents 8bdbd34 + c0eeb42 commit 8d13f4b

File tree

6 files changed

+41
-22
lines changed

6 files changed

+41
-22
lines changed

.github/ISSUE_TEMPLATE/1_Bug_report.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 🐛 Bug Report
2-
description: ⚠️ See below for security reports
2+
description: ⚠️ NEVER report security issues, read https://symfony.com/security instead
33
labels: Bug
44

55
body:

.github/ISSUE_TEMPLATE/3_Support_question.md

Lines changed: 0 additions & 11 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/4_Documentation_issue.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Support Question
4+
url: https://symfony.com/support
5+
about: We use GitHub issues only to discuss about Symfony bugs and new features. For this kind of questions about using Symfony or third-party bundles, please use any of the support alternatives shown in https://symfony.com/support
6+
- name: Documentation Issue
7+
url: https://github.com/symfony/symfony-docs/issues
8+
about: Symfony Documentation has its own dedicated repository.

UPGRADE-5.4.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,3 +170,19 @@ Security
170170
* Deprecate passing the strategy as string to `AccessDecisionManager`,
171171
pass an instance of `AccessDecisionStrategyInterface` instead
172172
* Flag `AccessDecisionManager` as `@final`
173+
* Deprecate passing `$credentials` to `PreAuthenticatedToken`,
174+
`SwitchUserToken` and `UsernamePasswordToken`:
175+
176+
Before:
177+
```php
178+
$token = new UsernamePasswordToken($user, $credentials, $firewallName, $roles);
179+
$token = new PreAuthenticatedToken($user, $credentials, $firewallName, $roles);
180+
$token = new SwitchUserToken($user, $credentials, $firewallName, $roles, $originalToken);
181+
```
182+
183+
After:
184+
```php
185+
$token = new UsernamePasswordToken($user, $firewallName, $roles);
186+
$token = new PreAuthenticatedToken($user, $firewallName, $roles);
187+
$token = new SwitchUserToken($user, $firewallName, $roles, $originalToken);
188+
```

UPGRADE-6.0.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,22 @@ Security
407407
```
408408
* `AccessDecisionManager` does not accept strings as strategy anymore,
409409
pass an instance of `AccessDecisionStrategyInterface` instead
410+
* Removed the `$credentials` argument of `PreAuthenticatedToken`,
411+
`SwitchUserToken` and `UsernamePasswordToken`:
412+
413+
Before:
414+
```php
415+
$token = new UsernamePasswordToken($user, $credentials, $firewallName, $roles);
416+
$token = new PreAuthenticatedToken($user, $credentials, $firewallName, $roles);
417+
$token = new SwitchUserToken($user, $credentials, $firewallName, $roles, $originalToken);
418+
```
419+
420+
After:
421+
```php
422+
$token = new UsernamePasswordToken($user, $firewallName, $roles);
423+
$token = new PreAuthenticatedToken($user, $firewallName, $roles);
424+
$token = new SwitchUserToken($user, $firewallName, $roles, $originalToken);
425+
```
410426

411427
SecurityBundle
412428
--------------

0 commit comments

Comments
 (0)