Skip to content

Commit 382d8b6

Browse files
committed
feature #1224 Add "type: module" for all packages and changing main -> module (weaverryan)
This PR was merged into the 2.x branch. Discussion ---------- Add "type: module" for all packages and changing main -> module | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Tickets | None | License | MIT Follow up on https://github.com/symfony/ux/pull/1202/files#r1367791334 We already use ESM inside of our packages. This makes that official with `type: module`. Some notes / questions: A) I believe, since we already ONLY made "modules" available, that this will have no effect on end users, but I'm not 100% sure about that. If someone is using `require` instead of `import`, it would affect them... but in that case, I believe `require` would not have worked before anyway. But if anyone knows better than I do, I'd appreciate your notes. B) Because we are a `type: module`, my impression is that `main` will not be used. And we can instead rely on `module`. tl;dr I believe these changes won't have user-facing effects, but I'm not 100% sure about that... though I'm pretty sure that if they DO have user-facing effects, it would be limited to people who are currently using `require` with these packages. Cheers! Commits ------- 592be5e683 Specifically adding type: module for all packages and changing main -> module
2 parents 4403ef2 + 3e03cff commit 382d8b6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

assets/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
{
22
"name": "@symfony/ux-live-component",
33
"description": "Live Component: bring server-side re-rendering & model binding to any element.",
4-
"main": "dist/live_controller.js",
4+
"module": "dist/live_controller.js",
5+
"type": "module",
56
"types": "dist/live_controller.d.ts",
67
"version": "1.0.0",
78
"config": {

0 commit comments

Comments
 (0)