Skip to content

Commit 48dc425

Browse files
committed
minor #1221 [CI][LiveComponent] Speed poll test (smnandre)
This PR was merged into the 2.x branch. Discussion ---------- [CI][LiveComponent] Speed poll test Divide every polling delay in the test by 2 cc `@ChqThomas` `@weaverryan` | Before | After | | - | - | | ![before](https://github.com/symfony/ux/assets/1359581/4439a4b4-0664-41f8-a25c-7b0b3583fe92) | ![after](https://github.com/symfony/ux/assets/1359581/c47afbaa-f310-4b68-be82-1e117b114380) | Commits ------- 51239256b6 Speed poll test
2 parents 20d254a + 5423d67 commit 48dc425

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

assets/test/controller/poll.test.ts

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe('LiveController polling Tests', () => {
4646

4747
it('is controllable via modifiers', async () => {
4848
const test = await createTest({ renderCount: 0 }, (data: any) => `
49-
<div ${initComponent(data)} data-poll="delay(500)|$render">
49+
<div ${initComponent(data)} data-poll="delay(250)|$render">
5050
<span>Render count: ${data.renderCount}</span>
5151
</div>
5252
`);
@@ -62,18 +62,18 @@ describe('LiveController polling Tests', () => {
6262
data.renderCount = 2;
6363
});
6464

65-
// only wait for about 500ms this time
65+
// only wait for about 250ms this time
6666
await waitFor(() => expect(test.element).toHaveTextContent('Render count: 1'), {
67-
timeout: 600
67+
timeout: 300
6868
});
6969
await waitFor(() => expect(test.element).toHaveTextContent('Render count: 2'), {
70-
timeout: 600
70+
timeout: 300
7171
});
7272
});
7373

7474
it('can also call a live action', async () => {
7575
const test = await createTest({ renderCount: 0 }, (data: any) => `
76-
<div ${initComponent(data)} data-poll="delay(500)|saveAction">
76+
<div ${initComponent(data)} data-poll="delay(250)|saveAction">
7777
<span>Render count: ${data.renderCount}</span>
7878
</div>
7979
`);
@@ -91,18 +91,18 @@ describe('LiveController polling Tests', () => {
9191
data.renderCount = 2;
9292
});
9393

94-
// only wait for about 500ms this time
94+
// only wait for about 250ms this time
9595
await waitFor(() => expect(test.element).toHaveTextContent('Render count: 1'), {
96-
timeout: 600
96+
timeout: 300
9797
});
9898
await waitFor(() => expect(test.element).toHaveTextContent('Render count: 2'), {
99-
timeout: 600
99+
timeout: 300
100100
});
101101
});
102102

103103
it('polling should stop if data-poll is removed', async () => {
104104
const test = await createTest({ keepPolling: true, renderCount: 0 }, (data: any) => `
105-
<div ${initComponent(data)} ${data.keepPolling ? 'data-poll="delay(500)|$render"' : ''}>
105+
<div ${initComponent(data)} ${data.keepPolling ? 'data-poll="delay(250)|$render"' : ''}>
106106
<span>Render count: ${data.renderCount}</span>
107107
</div>
108108
`);
@@ -119,27 +119,27 @@ describe('LiveController polling Tests', () => {
119119
data.keepPolling = false;
120120
});
121121

122-
// only wait for about 500ms this time
122+
// only wait for about 250ms this time
123123
await waitFor(() => expect(test.element).toHaveTextContent('Render count: 1'), {
124-
timeout: 600
124+
timeout: 300
125125
});
126126
await waitFor(() => expect(test.element).toHaveTextContent('Render count: 2'), {
127-
timeout: 600
127+
timeout: 300
128128
});
129-
// wait 1 more second... no more Ajax calls should be made
129+
// wait 500ms more... no more Ajax calls should be made
130130
const timeoutPromise = new Promise((resolve) => {
131131
setTimeout(() => {
132132
resolve(true);
133-
}, 1000);
133+
}, 500);
134134
});
135135
await waitFor(() => timeoutPromise, {
136-
timeout: 1500
136+
timeout: 750
137137
});
138138
});
139139

140140
it('stops polling after it disconnects', async () => {
141141
const test = await createTest({ renderCount: 0 }, (data: any) => `
142-
<div ${initComponent(data)} data-poll="delay(500)|$render">
142+
<div ${initComponent(data)} data-poll="delay(250)|$render">
143143
<span>Render count: ${data.renderCount}</span>
144144
</div>
145145
`);
@@ -150,20 +150,20 @@ describe('LiveController polling Tests', () => {
150150
data.renderCount = 1;
151151
});
152152

153-
// only wait for about 500ms this time
153+
// only wait for about 250ms this time
154154
await waitFor(() => expect(test.element).toHaveTextContent('Render count: 1'), {
155-
timeout: 600
155+
timeout: 300
156156
});
157157
// "remove" our controller from the page
158158
document.body.innerHTML = '<div>something else</div>';
159-
// wait 1 more second... no more Ajax calls should be made
159+
// wait 500ms more second... no more Ajax calls should be made
160160
const timeoutPromise = new Promise((resolve) => {
161161
setTimeout(() => {
162162
resolve(true);
163-
}, 1000);
163+
}, 500);
164164
});
165165
await waitFor(() => timeoutPromise, {
166-
timeout: 1500
166+
timeout: 750
167167
});
168168
});
169169

0 commit comments

Comments
 (0)