Skip to content

Commit 1ab717c

Browse files
committed
minor #1122 [CI] Fix deprecations (smnandre)
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [CI] Fix deprecations Fix multiple deprecations in CI workflows. ### [doctor-rst.yaml](https://github.com/symfony/ux/actions/workflows/doctor-rst.yaml) ``` DOCtor-RST The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. [...] ``` ### [test.yaml](https://github.com/symfony/ux/actions/runs/6209833130/workflow) Note: ~~the failing php-cs-fixer test is unrelated (cause: new rule in php-cs-fixer)~~ Update: fixed the cs problem, another CI bug appears... not sure if random (does not seem related at all) ``` JavaScript Coding Style The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. [...] ``` ``` Check for UnBuilt JS Dist Files The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2 [...] ``` ``` tests-js The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. [...] ``` ### [test_turbo.yaml](https://github.com/symfony/ux/actions/runs/6209833129) ``` phpstan The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. [...] ``` ``` tests (8.1, highest) The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. [...] ``` ``` tests (8.1, lowest) The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. [...] ``` Commits ------- 0d0c3af [CI] Fix deprecations
2 parents c1c19b9 + 0d0c3af commit 1ab717c

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

.github/workflows/doctor-rst.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
run: mkdir .cache
1717

1818
- name: Extract base branch name
19-
run: echo "##[set-output name=branch;]$(echo ${GITHUB_BASE_REF:=${GITHUB_REF##*/}})"
19+
run: echo "branch=$(echo ${GITHUB_BASE_REF:=${GITHUB_REF##*/}})" >> $GITHUB_OUTPUT
2020
id: extract_base_branch
2121

2222
- name: Cache DOCtor-RST

.github/workflows/test-turbo.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ubuntu-latest
1010
steps:
1111
- name: Checkout
12-
uses: actions/checkout@v2
12+
uses: actions/checkout@v3
1313

1414
- name: Setup PHP
1515
uses: shivammathur/setup-php@v2
@@ -52,7 +52,7 @@ jobs:
5252

5353
steps:
5454
- name: Checkout
55-
uses: actions/checkout@v2
55+
uses: actions/checkout@v3
5656

5757
- name: Setup PHP
5858
uses: shivammathur/setup-php@v2
@@ -69,7 +69,7 @@ jobs:
6969
id: yarn-cache-dir-path
7070
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
7171

72-
- uses: actions/cache@v2
72+
- uses: actions/cache@v3
7373
id: yarn-cache
7474
with:
7575
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}

.github/workflows/test.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
coding-style-php:
99
runs-on: ubuntu-latest
1010
steps:
11-
- uses: actions/checkout@master
11+
- uses: actions/checkout@v3
1212
- uses: shivammathur/setup-php@v2
1313
with:
1414
php-version: '8.1'
@@ -20,11 +20,11 @@ jobs:
2020
name: JavaScript Coding Style
2121
runs-on: ubuntu-latest
2222
steps:
23-
- uses: actions/checkout@master
23+
- uses: actions/checkout@v3
2424
- name: Get yarn cache directory path
2525
id: yarn-cache-dir-path
2626
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
27-
- uses: actions/cache@v2
27+
- uses: actions/cache@v3
2828
id: yarn-cache
2929
with:
3030
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
@@ -39,11 +39,11 @@ jobs:
3939
name: Check for UnBuilt JS Dist Files
4040
runs-on: ubuntu-latest
4141
steps:
42-
- uses: actions/checkout@master
42+
- uses: actions/checkout@v3
4343
- name: Get yarn cache directory path
4444
id: yarn-cache-dir-path
4545
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
46-
- uses: actions/cache@v2
46+
- uses: actions/cache@v3
4747
id: yarn-cache
4848
with:
4949
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
@@ -124,11 +124,11 @@ jobs:
124124
tests-js:
125125
runs-on: ubuntu-latest
126126
steps:
127-
- uses: actions/checkout@master
127+
- uses: actions/checkout@v3
128128
- name: Get yarn cache directory path
129129
id: yarn-cache-dir-path
130130
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
131-
- uses: actions/cache@v2
131+
- uses: actions/cache@v3
132132
id: yarn-cache
133133
with:
134134
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}

src/Turbo/tests/app/Kernel.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ public function artistFromSong(Request $request, EntityManagerInterface $doctrin
291291
if (!$artist) {
292292
throw new NotFoundHttpException();
293293
}
294-
$artist->name = $artist->name.' after change';
294+
$artist->name .= ' after change';
295295

296296
$doctrine->flush();
297297
}

0 commit comments

Comments
 (0)