Fixing bug where FormView was created before validation errors were removed

Author: weaverryan

src/LiveComponent/src/ComponentWithFormTrait.php

@@ -125,11 +125,12 @@ private function initializeFormValues(): void
 
     private function submitForm(bool $validateAll = true): void
     {
+        if (null !== $this->formView) {
+            throw new \LogicException('The submitForm() method is being called, but the FormView has already been built. Are you calling $this->getForm() - which creates the FormView - before submitting the form?');
+        }
+
         $form = $this->getFormInstance();
         $form->submit($this->formValues);
-        // re-extract the "view" values in case the submitted data
-        // changed the underlying data or structure of the form
-        $this->formValues = $this->extractFormValues($this->getForm());
 
         if ($validateAll) {
             // mark the entire component as validated
@@ -143,6 +144,10 @@ private function submitForm(bool $validateAll = true): void
             $this->clearErrorsForNonValidatedFields($form, $this->getFormName());
         }
 
+        // re-extract the "view" values in case the submitted data
+        // changed the underlying data or structure of the form
+        $this->formValues = $this->extractFormValues($this->getForm());
+
         if (!$form->isValid()) {
             throw new UnprocessableEntityHttpException('Form validation failed in component');
         }

src/LiveComponent/tests/Fixture/Dto/BlogPost.php

@@ -12,12 +12,14 @@
 namespace Symfony\UX\LiveComponent\Tests\Fixture\Dto;
 
 use Symfony\Component\Validator\Constraints\Length;
+use Symfony\Component\Validator\Constraints\NotBlank;
 
 class BlogPost
 {
+    #[NotBlank(message: 'The title field should not be blank')]
     public $title;
 
-    #[Length(min: 100)]
+    #[Length(min: 100, minMessage: 'The content field is too short')]
     public $content;
 
     public $comments = [];

src/LiveComponent/tests/Functional/Form/ComponentWithFormTest.php

@@ -55,15 +55,16 @@ public function testFormValuesRebuildAfterFormChanges(): void
                 'headers' => ['X-CSRF-TOKEN' => $token],
             ])
             ->assertStatus(422)
-            ->dump()
             // look for original embedded form
             ->assertContains('<textarea id="blog_post_form_comments_0_content"')
             // look for new embedded form
             ->assertContains('<textarea id="blog_post_form_comments_1_content"')
             // changed text is still present
             ->assertContains('changed description by user</textarea>')
             // check that validation happened and stuck
-            ->assertContains('This value is too short. It should have 100 characters or more.')
+            ->assertContains('The content field is too short')
+            // make sure the title field did not suddenly become validated
+            ->assertNotContains('The title field should not be blank')
             ->use(function (Crawler $crawler) {
                 $div = $crawler->filter('[data-controller="live"]');
                 $liveData = json_decode($div->attr('data-live-data-value'), true);