minor fixes from reviews

Author: kbond

src/LiveComponent/README.md

@@ -119,8 +119,8 @@ class RandomNumberComponent
 ```
 
 To transform this into a "live" component (i.e. one that
-can be re-rendered live on the frontend), replace
-component's `AsTwigComponent` attribute to `AsLiveComponent`:
+can be re-rendered live on the frontend), replace the
+component's `AsTwigComponent` attribute with `AsLiveComponent`:
 
 ```diff
 // src/Components/RandomNumberComponent.php
@@ -690,9 +690,9 @@ class PostFormComponent extends AbstractController
      * Needed so the same form can be re-created
      * when the component is re-rendered via Ajax.
      *
-     * The fieldName="" option is needed in this situation because
+     * The `fieldName` option is needed in this situation because
      * the form renders fields with names like `name="post[title]"`.
-     * We set fieldName="" so that this live prop doesn't collide
+     * We set `fieldName: ''` so that this live prop doesn't collide
      * with that data. The value - initialFormData - could be anything.
      */
     #[LiveProp(fieldName: 'initialFormData')]
@@ -1016,8 +1016,8 @@ class EditUserComponent
 }
 ```
 
-Be sure to add the `Assert\IsValid` to any property where you want
-the object on that property to also be validated.
+Be sure to add the `IsValid` attribute/annotation to any property where
+you want the object on that property to also be validated.
 
 Thanks to this setup, the component will now be automatically validated
 on each render, but in a smart way: a property will only be validated

src/LiveComponent/src/Attribute/AsLiveComponent.php

@@ -24,13 +24,11 @@ final class AsLiveComponent extends AsTwigComponent
     /**
      * @internal
      *
-     * @param string|object $classOrObject
-     *
      * @return LivePropContext[]
      */
-    public static function liveProps($classOrObject): \Traversable
+    public static function liveProps(object $component): \Traversable
     {
-        foreach (self::propertiesFor($classOrObject) as $property) {
+        foreach (self::propertiesFor($component) as $property) {
             if ($attribute = $property->getAttributes(LiveProp::class)[0] ?? null) {
                 yield new LivePropContext($attribute->newInstance(), $property);
             }
@@ -39,12 +37,10 @@ public static function liveProps($classOrObject): \Traversable
 
     /**
      * @internal
-     *
-     * @param string|object $classOrObject
      */
-    public static function isActionAllowed($classOrObject, string $action): bool
+    public static function isActionAllowed(object $component, string $action): bool
     {
-        foreach (self::attributeMethodsFor(LiveAction::class, $classOrObject) as $method) {
+        foreach (self::attributeMethodsFor(LiveAction::class, $component) as $method) {
             if ($action === $method->getName()) {
                 return true;
             }
@@ -56,61 +52,53 @@ public static function isActionAllowed($classOrObject, string $action): bool
     /**
      * @internal
      *
-     * @param string|object $classOrObject
-     *
      * @return \ReflectionMethod[]
      */
-    public static function beforeReRenderMethods($classOrObject): \Traversable
+    public static function beforeReRenderMethods(object $component): \Traversable
     {
-        yield from self::attributeMethodsFor(BeforeReRender::class, $classOrObject);
+        yield from self::attributeMethodsFor(BeforeReRender::class, $component);
     }
 
     /**
      * @internal
      *
-     * @param string|object $classOrObject
-     *
      * @return \ReflectionMethod[]
      */
-    public static function postHydrateMethods($classOrObject): \Traversable
+    public static function postHydrateMethods(object $component): \Traversable
     {
-        yield from self::attributeMethodsFor(PostHydrate::class, $classOrObject);
+        yield from self::attributeMethodsFor(PostHydrate::class, $component);
     }
 
     /**
      * @internal
      *
-     * @param string|object $classOrObject
-     *
      * @return \ReflectionMethod[]
      */
-    public static function preDehydrateMethods($classOrObject): \Traversable
+    public static function preDehydrateMethods(object $component): \Traversable
     {
-        yield from self::attributeMethodsFor(PreDehydrate::class, $classOrObject);
+        yield from self::attributeMethodsFor(PreDehydrate::class, $component);
     }
 
     /**
      * @param string|object $classOrObject
      *
      * @return \ReflectionMethod[]
      */
-    private static function attributeMethodsFor(string $attribute, $classOrObject): \Traversable
+    private static function attributeMethodsFor(string $attribute, object $component): \Traversable
     {
-        foreach ((new \ReflectionClass($classOrObject))->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
+        foreach ((new \ReflectionClass($component))->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
             if ($method->getAttributes($attribute)[0] ?? null) {
                 yield $method;
             }
         }
     }
 
     /**
-     * @param string|object $classOrObject
-     *
      * @return \ReflectionProperty[]
      */
-    private static function propertiesFor($classOrObject): \Traversable
+    private static function propertiesFor(object $object): \Traversable
     {
-        $class = $classOrObject instanceof \ReflectionClass ? $classOrObject : new \ReflectionClass($classOrObject);
+        $class = $object instanceof \ReflectionClass ? $object : new \ReflectionClass($object);
 
         foreach ($class->getProperties() as $property) {
             yield $property;

src/LiveComponent/src/EventListener/LiveComponentSubscriber.php

@@ -45,6 +45,7 @@ class LiveComponentSubscriber implements EventSubscriberInterface, ServiceSubscr
     private const JSON_FORMAT = 'live-component-json';
     private const JSON_CONTENT_TYPE = 'application/vnd.live-component+json';
 
+    /** @var array<string, string> */
     private array $componentServiceMap;
     private ContainerInterface $container;