fix for fetching live props from parent class

Author: kbond

src/LiveComponent/src/Attribute/AsLiveComponent.php

@@ -28,10 +28,21 @@ final class AsLiveComponent extends AsTwigComponent
      */
     public static function liveProps(object $component): \Traversable
     {
+        $properties = [];
+
         foreach (self::propertiesFor($component) as $property) {
-            if ($attribute = $property->getAttributes(LiveProp::class)[0] ?? null) {
-                yield new LivePropContext($attribute->newInstance(), $property);
+            if (!$attribute = $property->getAttributes(LiveProp::class)[0] ?? null) {
+                continue;
+            }
+
+            if (\in_array($property->getName(), $properties, true)) {
+                // property name was already used
+                continue;
             }
+
+            $properties[] = $property->getName();
+
+            yield new LivePropContext($attribute->newInstance(), $property);
         }
     }
 

src/LiveComponent/tests/Fixture/Component/Component4.php

@@ -20,15 +20,15 @@
 /**
  * @author Kevin Bond <[email protected]>
  */
-final class Component4
+class Component4
 {
     #[LiveProp]
     public $prop1;
 
     public $prop2;
 
     #[LiveProp]
-    public $prop3;
+    private $prop3;
 
     #[LiveAction]
     public function method1()

src/LiveComponent/tests/Fixture/Component/Component5.php

@@ -0,0 +1,19 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\UX\LiveComponent\Tests\Fixture\Component;
+
+/**
+ * @author Kevin Bond <[email protected]>
+ */
+final class Component5 extends Component4
+{
+}

src/LiveComponent/tests/Unit/Attribute/AsLiveComponentTest.php

@@ -13,7 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\UX\LiveComponent\Attribute\AsLiveComponent;
-use Symfony\UX\LiveComponent\Tests\Fixture\Component\Component4;
+use Symfony\UX\LiveComponent\Tests\Fixture\Component\Component5;
 
 /**
  * @author Kevin Bond <[email protected]>
@@ -22,7 +22,7 @@ final class AsLiveComponentTest extends TestCase
 {
     public function testCanGetLiveProps(): void
     {
-        $props = iterator_to_array(AsLiveComponent::liveProps(new Component4()));
+        $props = iterator_to_array(AsLiveComponent::liveProps(new Component5()));
 
         $this->assertCount(2, $props);
         $this->assertSame('prop1', $props[0]->reflectionProperty()->getName());
@@ -31,31 +31,31 @@ public function testCanGetLiveProps(): void
 
     public function testCanGetPreDehydrateMethods(): void
     {
-        $methods = iterator_to_array(AsLiveComponent::preDehydrateMethods(new Component4()));
+        $methods = iterator_to_array(AsLiveComponent::preDehydrateMethods(new Component5()));
 
         $this->assertCount(1, $methods);
         $this->assertSame('method4', $methods[0]->getName());
     }
 
     public function testCanGetPostHydrateMethods(): void
     {
-        $methods = iterator_to_array(AsLiveComponent::postHydrateMethods(new Component4()));
+        $methods = iterator_to_array(AsLiveComponent::postHydrateMethods(new Component5()));
 
         $this->assertCount(1, $methods);
         $this->assertSame('method5', $methods[0]->getName());
     }
 
     public function testCanGetBeforeReRenderMethods(): void
     {
-        $methods = iterator_to_array(AsLiveComponent::beforeReRenderMethods(new Component4()));
+        $methods = iterator_to_array(AsLiveComponent::beforeReRenderMethods(new Component5()));
 
         $this->assertCount(1, $methods);
         $this->assertSame('method3', $methods[0]->getName());
     }
 
     public function testCanCheckIfMethodIsAllowed(): void
     {
-        $component = new Component4();
+        $component = new Component5();
 
         $this->assertTrue(AsLiveComponent::isActionAllowed($component, 'method1'));
         $this->assertFalse(AsLiveComponent::isActionAllowed($component, 'method2'));