Skip to content

Commit 6040306

Browse files
committed
[Live] Fixing completely incorrect attribute name for fingerprint
1 parent 9f313bc commit 6040306

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/LiveComponent/src/EventListener/AddLiveAttributesSubscriber.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ private function getLiveAttributes(MountedComponent $mounted, ComponentMetadata
118118
}
119119

120120
$fingerprint = $this->container->get(FingerprintCalculator::class)->calculateFingerprint($mounted->getInputProps());
121-
$attributes['data-live-value-fingerprint'] = $helper->escapeAttribute($fingerprint);
121+
$attributes['data-live-fingerprint-value'] = $helper->escapeAttribute($fingerprint);
122122
}
123123

124124
return new ComponentAttributes($attributes);

src/LiveComponent/tests/Functional/EventListener/AddLiveAttributesSubscriberTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,10 @@ public function testItAddsIdAndFingerprintToChildComponent(): void
9696

9797
// fingerprints
9898
// first and last both have the same input - thus fingerprint
99-
$this->assertSame('sH/Rwn0x37n3KyMWQLa6OBPgglriBZqlwPLnm/EQTlE=', $lis->first()->attr('data-live-value-fingerprint'));
100-
$this->assertSame('sH/Rwn0x37n3KyMWQLa6OBPgglriBZqlwPLnm/EQTlE=', $lis->last()->attr('data-live-value-fingerprint'));
99+
$this->assertSame('sH/Rwn0x37n3KyMWQLa6OBPgglriBZqlwPLnm/EQTlE=', $lis->first()->attr('data-live-fingerprint-value'));
100+
$this->assertSame('sH/Rwn0x37n3KyMWQLa6OBPgglriBZqlwPLnm/EQTlE=', $lis->last()->attr('data-live-fingerprint-value'));
101101
// middle has a different fingerprint
102-
$this->assertSame('cuOKkrHC9lOmBa6dyVZ3S0REdw4CKCwJgLDdrVoTb2g=', $lis->eq(1)->attr('data-live-value-fingerprint'));
102+
$this->assertSame('cuOKkrHC9lOmBa6dyVZ3S0REdw4CKCwJgLDdrVoTb2g=', $lis->eq(1)->attr('data-live-fingerprint-value'));
103103
}
104104

105105
public function testItDoesNotOverrideDataLiveIdIfSpecified(): void

ux.symfony.com/assets/bootstrap.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { startStimulusApp } from '@symfony/stimulus-bridge';
22
import Clipboard from 'stimulus-clipboard'
3+
import Live from '../live_components';
34

45
// Registers Stimulus controllers from controllers.json and in the controllers/ directory
56
export const app = startStimulusApp(require.context(

0 commit comments

Comments
 (0)