bug #165 [LiveComponent] fix silent serializer/doctrine dependency issue (kbond)

This PR was merged into the main branch.

Discussion
----------

[LiveComponent] fix silent serializer/doctrine dependency issue

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Tickets       | Fix #164
| License       | MIT

Commits
-------

da043dc [LiveComponent] fix silent serializer/doctrine dependency issue (fixes #164)

Author: kbond

src/LiveComponent/src/DependencyInjection/Compiler/OptionalDependencyPass.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace Symfony\UX\LiveComponent\DependencyInjection\Compiler;
+
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Reference;
+use Symfony\UX\LiveComponent\Hydrator\DoctrineEntityPropertyHydrator;
+use Symfony\UX\LiveComponent\Hydrator\NormalizerBridgePropertyHydrator;
+
+/**
+ * @author Kevin Bond <[email protected]>
+ */
+final class OptionalDependencyPass implements CompilerPassInterface
+{
+    public function process(ContainerBuilder $container): void
+    {
+        if ($container->hasDefinition('doctrine')) {
+            $container->register('ux.live_component.doctrine_entity_property_hydrator', DoctrineEntityPropertyHydrator::class)
+                ->setArguments([[new Reference('doctrine')]])
+                ->addTag('twig.component.property_hydrator', ['priority' => -100])
+            ;
+        }
+
+        if ($container->hasDefinition('serializer')) {
+            $container->register('ux.live_component.serializer_property_hydrator', NormalizerBridgePropertyHydrator::class)
+                ->setArguments([new Reference('serializer')])
+                ->addTag('twig.component.property_hydrator', ['priority' => -200])
+            ;
+        }
+    }
+}

src/LiveComponent/src/DependencyInjection/LiveComponentExtension.php

@@ -22,8 +22,6 @@
 use Symfony\UX\LiveComponent\ComponentValidator;
 use Symfony\UX\LiveComponent\ComponentValidatorInterface;
 use Symfony\UX\LiveComponent\EventListener\LiveComponentSubscriber;
-use Symfony\UX\LiveComponent\Hydrator\DoctrineEntityPropertyHydrator;
-use Symfony\UX\LiveComponent\Hydrator\NormalizerBridgePropertyHydrator;
 use Symfony\UX\LiveComponent\LiveComponentHydrator;
 use Symfony\UX\LiveComponent\PropertyHydratorInterface;
 use Symfony\UX\LiveComponent\Twig\LiveComponentExtension as LiveComponentTwigExtension;
@@ -60,16 +58,6 @@ function (ChildDefinition $definition, AsLiveComponent $attribute) {
             ->addTag('twig.component.property_hydrator')
         ;
 
-        $container->register('ux.live_component.doctrine_entity_property_hydrator', DoctrineEntityPropertyHydrator::class)
-            ->setArguments([[new Reference('doctrine')]])
-            ->addTag('twig.component.property_hydrator', ['priority' => -100])
-        ;
-
-        $container->register('ux.live_component.serializer_property_hydrator', NormalizerBridgePropertyHydrator::class)
-            ->setArguments([new Reference('serializer')])
-            ->addTag('twig.component.property_hydrator', ['priority' => -200])
-        ;
-
         $container->register('ux.live_component.component_hydrator', LiveComponentHydrator::class)
             ->setArguments([
                 new TaggedIteratorArgument('twig.component.property_hydrator'),

src/LiveComponent/src/LiveComponentBundle.php

@@ -11,7 +11,9 @@
 
 namespace Symfony\UX\LiveComponent;
 
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
+use Symfony\UX\LiveComponent\DependencyInjection\Compiler\OptionalDependencyPass;
 
 /**
  * @author Kevin Bond <[email protected]>
@@ -20,4 +22,8 @@
  */
 final class LiveComponentBundle extends Bundle
 {
+    public function build(ContainerBuilder $container): void
+    {
+        $container->addCompilerPass(new OptionalDependencyPass());
+    }
 }