Skip to content

Commit 71f49ae

Browse files
committed
Rebuild dist assets
JSON -> HTML update missed build step breaking live component
1 parent 0f4e70e commit 71f49ae

File tree

3 files changed

+14
-25
lines changed

3 files changed

+14
-25
lines changed

src/Dropzone/Resources/assets/dist/controller.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class default_1 extends Controller {
4343
});
4444
reader.readAsDataURL(file);
4545
}
46-
_dispatchEvent(name, payload) {
46+
_dispatchEvent(name, payload = {}) {
4747
this.element.dispatchEvent(new CustomEvent(name, { detail: payload }));
4848
}
4949
}

src/LazyImage/Resources/assets/dist/controller.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ import { Controller } from '@hotwired/stimulus';
33
class default_1 extends Controller {
44
connect() {
55
const hd = new Image();
6+
const element = this.element;
67
const srcsetString = this._calculateSrcsetString();
78
hd.addEventListener('load', () => {
8-
this.element.src = this.srcValue;
9+
element.src = this.srcValue;
910
if (srcsetString) {
10-
this.element.srcset = srcsetString;
11+
element.srcset = srcsetString;
1112
}
1213
this._dispatchEvent('lazy-image:ready', { image: hd });
1314
});

src/LiveComponent/assets/dist/live_controller.js

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1130,15 +1130,7 @@ class default_1 extends Controller {
11301130
this._makeRequest(null);
11311131
}
11321132
_getValueFromElement(element) {
1133-
const value = element.dataset.value || element.value;
1134-
if (!value) {
1135-
const clonedElement = (element.cloneNode());
1136-
if (!(clonedElement instanceof HTMLElement)) {
1137-
throw new Error('cloneNode() produced incorrect type');
1138-
}
1139-
throw new Error(`The update() method could not be called for "${clonedElement.outerHTML}": the element must either have a "data-value" or "value" attribute set.`);
1140-
}
1141-
return value;
1133+
return element.dataset.value || element.value;
11421134
}
11431135
_updateModelFromElement(element, value, shouldRender) {
11441136
const model = element.dataset.model || element.getAttribute('name');
@@ -1202,7 +1194,7 @@ class default_1 extends Controller {
12021194
}
12031195
const fetchOptions = {};
12041196
fetchOptions.headers = {
1205-
'Accept': 'application/vnd.live-component+json',
1197+
'Accept': 'application/vnd.live-component+html',
12061198
};
12071199
if (action) {
12081200
url += `/${encodeURIComponent(action)}`;
@@ -1228,34 +1220,30 @@ class default_1 extends Controller {
12281220
}
12291221
const isMostRecent = this.renderPromiseStack.removePromise(thisPromise);
12301222
if (isMostRecent) {
1231-
response.json().then((data) => {
1232-
this._processRerender(data);
1223+
response.text().then((html) => {
1224+
this._processRerender(html, response);
12331225
});
12341226
}
12351227
});
12361228
}
1237-
_processRerender(data) {
1229+
_processRerender(html, response) {
12381230
if (this.isWindowUnloaded) {
12391231
return;
12401232
}
1241-
if (data.redirect_url) {
1233+
if (response.headers.get('Location')) {
12421234
if (typeof Turbo !== 'undefined') {
1243-
Turbo.visit(data.redirect_url);
1235+
Turbo.visit(response.headers.get('Location'));
12441236
}
12451237
else {
1246-
window.location.href = data.redirect_url;
1238+
window.location.href = response.headers.get('Location') || '';
12471239
}
12481240
return;
12491241
}
1250-
if (!this._dispatchEvent('live:render', data, true, true)) {
1242+
if (!this._dispatchEvent('live:render', html, true, true)) {
12511243
return;
12521244
}
12531245
this._onLoadingFinish();
1254-
if (!data.html) {
1255-
throw new Error('Missing html key on response JSON');
1256-
}
1257-
this._executeMorphdom(data.html);
1258-
this.dataValue = data.data;
1246+
this._executeMorphdom(html);
12591247
}
12601248
_clearWaitingDebouncedRenders() {
12611249
if (this.renderDebounceTimeout) {

0 commit comments

Comments
 (0)