Log warning if icon is not found

Author: smnandre

src/Icons/composer.json

@@ -45,7 +45,8 @@
         "symfony/http-client": "6.4|^7.0",
         "symfony/phpunit-bridge": "^6.3|^7.0",
         "symfony/ux-twig-component": "^2.14",
-        "zenstruck/console-test": "^1.5"
+        "zenstruck/console-test": "^1.5",
+        "psr/log": "^2|^3"
     },
     "config": {
         "sort-packages": true

src/Icons/config/services.php

@@ -49,6 +49,7 @@
             ->args([
                 service('.ux_icons.icon_renderer'),
                 abstract_arg('ignore_not_found'),
+                service('logger')->ignoreOnInvalid(),
             ])
             ->tag('twig.runtime')
 

src/Icons/src/Twig/UXIconRuntime.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\UX\Icons\Twig;
 
+use Psr\Log\LoggerInterface;
 use Symfony\UX\Icons\Exception\IconNotFoundException;
 use Symfony\UX\Icons\IconRendererInterface;
 use Twig\Extension\RuntimeExtensionInterface;
@@ -25,6 +26,7 @@ final class UXIconRuntime implements RuntimeExtensionInterface
     public function __construct(
         private readonly IconRendererInterface $iconRenderer,
         private readonly bool $ignoreNotFound = false,
+        private readonly ?LoggerInterface $logger = null,
     ) {
     }
 
@@ -37,6 +39,7 @@ public function renderIcon(string $name, array $attributes = []): string
             return $this->iconRenderer->renderIcon($name, $attributes);
         } catch (IconNotFoundException $e) {
             if ($this->ignoreNotFound) {
+                $this->logger?->warning($e->getMessage());
                 return '';
             }
 

src/Icons/tests/Unit/Twig/UXIconRuntimeTest.php

@@ -12,6 +12,7 @@
 namespace Symfony\UX\Icons\Tests\Unit\Twig;
 
 use PHPUnit\Framework\TestCase;
+use Psr\Log\LoggerInterface;
 use Symfony\UX\Icons\Exception\IconNotFoundException;
 use Symfony\UX\Icons\IconRendererInterface;
 use Symfony\UX\Icons\Twig\UXIconRuntime;
@@ -21,13 +22,18 @@
  */
 class UXIconRuntimeTest extends TestCase
 {
-    public function testRenderIconIgnoreMissing(): void
+    public function testRenderIconIgnoreNotFound(): void
     {
         $renderer = $this->createMock(IconRendererInterface::class);
         $renderer->method('renderIcon')
-            ->willThrowException(new IconNotFoundException('not_found'));
+            ->willThrowException(new IconNotFoundException('Icon "foo" not found.'));
 
-        $runtime = new UXIconRuntime($renderer, true);
+        $logger = $this->createMock(LoggerInterface::class);
+        $logger->expects($this->once())
+            ->method('warning')
+            ->with('Icon "foo" not found.');
+
+        $runtime = new UXIconRuntime($renderer, true, $logger);
         $this->assertEquals('', $runtime->renderIcon('not_found'));
 
         $runtime = new UXIconRuntime($renderer, false);