bug #295 [Live] fix bug when trying to hydrate nullable Doctrine Entity (kbond)

This PR was merged into the 2.x branch.

Discussion
----------

[Live] fix bug when trying to hydrate nullable Doctrine Entity

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Tickets       | n/a
| License       | MIT

Fixes a regression in 2.1 where a nullable entity is attempted to be loaded from Doctrine. In 2.0, `null` was dropped from the component data loading the entity wasn't attempted.

Commits
-------

03188d8 [Live] fix bug when trying to hydrate nullable Doctrine Entity

Author: weaverryan

src/LiveComponent/src/Normalizer/DoctrineObjectNormalizer.php

@@ -66,7 +66,7 @@ public function supportsNormalization(mixed $data, string $format = null, array
 
     public function denormalize(mixed $data, string $type, string $format = null, array $context = []): ?object
     {
-        return $this->objectManagerFor($type)->find($type, $data);
+        return null === $data ? null : $this->objectManagerFor($type)->find($type, $data);
     }
 
     public function supportsDenormalization(mixed $data, string $type, string $format = null, array $context = [])

src/LiveComponent/tests/Fixtures/Component/WithNullableEntity.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Symfony\UX\LiveComponent\Tests\Fixtures\Component;
+
+use Symfony\UX\LiveComponent\Attribute\AsLiveComponent;
+use Symfony\UX\LiveComponent\Attribute\LiveProp;
+use Symfony\UX\LiveComponent\DefaultActionTrait;
+use Symfony\UX\LiveComponent\Tests\Fixtures\Entity\Entity1;
+
+/**
+ * @author Kevin Bond <[email protected]>
+ */
+#[AsLiveComponent('with_nullable_entity')]
+final class WithNullableEntity
+{
+    use DefaultActionTrait;
+
+    #[LiveProp]
+    public ?Entity1 $prop1 = null;
+}

src/LiveComponent/tests/Fixtures/templates/components/with_nullable_entity.html.twig

@@ -0,0 +1 @@
+Prop1: {{ prop1.id|default('default') }}

src/LiveComponent/tests/Functional/EventListener/LiveComponentSubscriberTest.php

@@ -210,4 +210,16 @@ public function testInjectsLiveArgs(): void
             ->assertContains('Arg3: 33.3')
         ;
     }
+
+    public function testWithNullableEntity(): void
+    {
+        $dehydrated = $this->dehydrateComponent($this->mountComponent('with_nullable_entity'));
+
+        $this->browser()
+            ->throwExceptions()
+            ->get('/_components/with_nullable_entity?data='.urlencode(json_encode($dehydrated)))
+            ->assertSuccessful()
+            ->assertContains('Prop1: default')
+        ;
+    }
 }

src/TwigComponent/src/ComponentFactory.php

@@ -71,7 +71,7 @@ public function create(string $name, array $data = []): MountedComponent
 
         // ensure remaining data is scalar
         foreach ($data as $key => $value) {
-            if (!is_scalar($value) && null !== $value) {
+            if (!\is_scalar($value) && null !== $value) {
                 throw new \LogicException(sprintf('Unable to use "%s" (%s) as an attribute. Attributes must be scalar or null. If you meant to mount this value on "%s", make sure "$%1$s" is a writable property or create a mount() method with a "$%1$s" argument.', $key, get_debug_type($value), $component::class));
             }
         }