Return early and throw on unsupported element

Author: Lustmored

src/LiveComponent/assets/src/update_array_data.ts

@@ -28,17 +28,24 @@ export function updateArrayDataFromChangedElement(
             if (index === -1) {
                 currentValues.push(value);
             }
-        } else {
-            // Remove value from an array
-            if (index > -1) {
-                currentValues.splice(index, 1);
-            }
+
+            return currentValues;
+        }
+
+        // Remove value from an array
+        if (index > -1) {
+            currentValues.splice(index, 1);
         }
-    } else if (element instanceof HTMLSelectElement) {
+
+        return currentValues;
+    }
+
+    if (element instanceof HTMLSelectElement) {
         // Select elements with `multiple` option require mapping chosen options to their values
         currentValues = Array.from(element.selectedOptions).map(el => el.value);
+
+        return currentValues;
     }
 
-    // When no values are selected for collection no data should be sent over the wire
-    return currentValues;
+    throw new Error(`The element used to determine array data from is unsupported (${element.tagName} provided)`);
 }

src/LiveComponent/assets/test/update_array_data.test.ts

@@ -51,4 +51,11 @@ describe('getArrayValue', () => {
         expect(updateArrayDataFromChangedElement(select, '', null))
             .toEqual(['foo', 'bar']);
     })
+
+    it('Throws on unsupported elements', () => {
+        const div = document.createElement('div');
+
+        expect(() => updateArrayDataFromChangedElement(div, '', null))
+            .toThrowError('The element used to determine array data from is unsupported (DIV provided)')
+    });
 });