Pass component metadata to pre and post mount events

Author: squrious

src/LiveComponent/src/EventListener/QueryStringInitializeSubscriber.php

@@ -16,7 +16,6 @@
 use Symfony\UX\LiveComponent\Metadata\LiveComponentMetadata;
 use Symfony\UX\LiveComponent\Metadata\LiveComponentMetadataFactory;
 use Symfony\UX\LiveComponent\Util\QueryStringPropsExtractor;
-use Symfony\UX\TwigComponent\Event\PreCreateForRenderEvent;
 use Symfony\UX\TwigComponent\Event\PreMountEvent;
 
 /**
@@ -43,18 +42,23 @@ public function __construct(
     public static function getSubscribedEvents(): array
     {
         return [
-            PreCreateForRenderEvent::class => 'onPreCreateForRenderEvent',
             PreMountEvent::class => 'onPreMount',
         ];
     }
 
     public function onPreMount(PreMountEvent $event): void
     {
-        $component = $event->getComponent();
-        if (!($metadata = $this->registered[$component::class] ?? null)) {
+        $metadata = new LiveComponentMetadata(
+            $event->getMetadata(),
+            $this->metadataFactory->createPropMetadatas(new \ReflectionClass($event->getComponent()::class))
+        );
+
+        if (!$metadata->hasQueryStringBindings()) {
             return;
         }
 
+        $component = $event->getComponent();
+
         $data = $event->getData();
 
         $request = $this->requestStack->getMainRequest();
@@ -63,13 +67,4 @@ public function onPreMount(PreMountEvent $event): void
 
         $event->setData(array_merge($data, $queryStringData));
     }
-
-    public function onPreCreateForRenderEvent(PreCreateForRenderEvent $event): void
-    {
-        $componentName = $event->getName();
-        $metadata = $this->metadataFactory->getMetadata($componentName);
-        if ($metadata->hasQueryStringBindings()) {
-            $this->registered[$metadata->getComponentMetadata()->getClass()] = $metadata;
-        }
-    }
 }

src/TwigComponent/src/ComponentFactory.php

@@ -75,7 +75,7 @@ public function create(string $name, array $data = []): MountedComponent
     public function mountFromObject(object $component, array $data, ComponentMetadata $componentMetadata): MountedComponent
     {
         $originalData = $data;
-        $data = $this->preMount($component, $data);
+        $data = $this->preMount($component, $data, $componentMetadata);
 
         $this->mount($component, $data);
 
@@ -88,7 +88,7 @@ public function mountFromObject(object $component, array $data, ComponentMetadat
             }
         }
 
-        $postMount = $this->postMount($component, $data);
+        $postMount = $this->postMount($component, $data, $componentMetadata);
         $data = $postMount['data'];
         $extraMetadata = $postMount['extraMetadata'];
 
@@ -174,9 +174,9 @@ private function getComponent(string $name): object
         return $this->components->get($name);
     }
 
-    private function preMount(object $component, array $data): array
+    private function preMount(object $component, array $data, ComponentMetadata $componentMetadata): array
     {
-        $event = new PreMountEvent($component, $data);
+        $event = new PreMountEvent($component, $data, $componentMetadata);
         $this->eventDispatcher->dispatch($event);
         $data = $event->getData();
 
@@ -194,9 +194,9 @@ private function preMount(object $component, array $data): array
     /**
      * @return array{data: array<string, mixed>, extraMetadata: array<string, mixed>}
      */
-    private function postMount(object $component, array $data): array
+    private function postMount(object $component, array $data, ComponentMetadata $componentMetadata): array
     {
-        $event = new PostMountEvent($component, $data);
+        $event = new PostMountEvent($component, $data, $componentMetadata);
         $this->eventDispatcher->dispatch($event);
         $data = $event->getData();
         $extraMetadata = $event->getExtraMetadata();

src/TwigComponent/src/Event/PostMountEvent.php

@@ -12,6 +12,7 @@
 namespace Symfony\UX\TwigComponent\Event;
 
 use Symfony\Contracts\EventDispatcher\Event;
+use Symfony\UX\TwigComponent\ComponentMetadata;
 
 /**
  * @author Ryan Weaver <[email protected]>
@@ -21,6 +22,7 @@ final class PostMountEvent extends Event
     public function __construct(
         private object $component,
         private array $data,
+        private ComponentMetadata $metadata,
         private array $extraMetadata = [],
     ) {
     }
@@ -40,6 +42,11 @@ public function setData(array $data): void
         $this->data = $data;
     }
 
+    public function getMetadata(): ComponentMetadata
+    {
+        return $this->metadata;
+    }
+
     public function getExtraMetadata(): array
     {
         return $this->extraMetadata;

src/TwigComponent/src/Event/PreMountEvent.php

@@ -12,13 +12,14 @@
 namespace Symfony\UX\TwigComponent\Event;
 
 use Symfony\Contracts\EventDispatcher\Event;
+use Symfony\UX\TwigComponent\ComponentMetadata;
 
 /**
  * @author Ryan Weaver <[email protected]>
  */
 final class PreMountEvent extends Event
 {
-    public function __construct(private object $component, private array $data)
+    public function __construct(private object $component, private array $data, private ComponentMetadata $metadata)
     {
     }
 
@@ -36,4 +37,9 @@ public function setData(array $data): void
     {
         $this->data = $data;
     }
+
+    public function getMetadata(): ComponentMetadata
+    {
+        return $this->metadata;
+    }
 }

src/TwigComponent/tests/Unit/EventListener/TwigComponentLoggerListenerTest.php

@@ -38,9 +38,9 @@ public function testLoggerStoreEvents(): void
         $eventB = new PreCreateForRenderEvent('b');
         $logger->onPreCreateForRender($eventB);
 
-        $eventC = new PreMountEvent(new \stdClass(), []);
+        $eventC = new PreMountEvent(new \stdClass(), [], new ComponentMetadata([]));
         $logger->onPreMount($eventC);
-        $eventD = new PostMountEvent(new \stdClass(), []);
+        $eventD = new PostMountEvent(new \stdClass(), [], new ComponentMetadata([]));
         $logger->onPostMount($eventD);
 
         $mounted = new MountedComponent('foo', new \stdClass(), new ComponentAttributes([]));