Upgrading all packages to Stimulus 3

Author: weaverryan

.github/workflows/test.yaml

@@ -80,25 +80,21 @@ jobs:
             - name: Chartjs
               run: |
                   cd src/Chartjs
-                  composer config platform.php 7.4.99
                   composer update --prefer-dist --no-interaction --no-ansi --no-progress
                   php vendor/bin/simple-phpunit
             - name: Cropperjs
               run: |
                   cd src/Cropperjs
-                  composer config platform.php 7.4.99
                   composer update --prefer-dist --no-interaction --no-ansi --no-progress
                   php vendor/bin/simple-phpunit
             - name: Dropzone
               run: |
                   cd src/Dropzone
-                  composer config platform.php 7.4.99
                   composer update --prefer-dist --no-interaction --no-ansi --no-progress
                   php vendor/bin/simple-phpunit
             - name: LazyImage
               run: |
                   cd src/LazyImage
-                  composer config platform.php 7.4.99
                   composer update --prefer-dist --no-interaction --no-ansi --no-progress
                   php vendor/bin/simple-phpunit
             - name: TwigComponent

src/Chartjs/CHANGELOG.md

@@ -1,7 +1,10 @@
 # CHANGELOG
 
-## 1.4
+## 2.0
 
+-   Support for `stimulus` version 2 was removed and support for `@hotwired/stimulus`
+    version 3 was added. See the [@symfony/stimulus-bridge CHANGELOG](https://github.com/symfony/stimulus-bridge/blob/main/CHANGELOG.md#300)
+    for more details.
 -   Support added for Symfony 6
 
 ## 1.3

src/Chartjs/README.md

@@ -84,7 +84,7 @@ Symfony UX Chart.js allows you to extend its default behavior using a custom Sti
 ```js
 // mychart_controller.js
 
-import { Controller } from 'stimulus';
+import { Controller } from '@hotwired/stimulus';
 
 export default class extends Controller {
     connect() {

src/Chartjs/Resources/assets/dist/controller.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports["default"] = void 0;
 
-var _stimulus = require("stimulus");
+var _stimulus = require("@hotwired/stimulus");
 
 var _chart = require("chart.js");
 
@@ -35,7 +35,7 @@ function _possibleConstructorReturn(self, call) { if (call && (_typeof(call) ===
 
 function _assertThisInitialized(self) { if (self === void 0) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return self; }
 
-function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Date.prototype.toString.call(Reflect.construct(Date, [], function () {})); return true; } catch (e) { return false; } }
+function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
 
 function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); }
 

src/Chartjs/Resources/assets/package.json

@@ -20,7 +20,7 @@
     },
     "peerDependencies": {
         "chart.js": "^2.9.4",
-        "stimulus": "^2.0.0"
+        "@hotwired/stimulus": "^3.0.0"
     },
     "devDependencies": {
         "@babel/cli": "^7.12.1",
@@ -30,7 +30,7 @@
         "@symfony/stimulus-testing": "^1.1.0",
         "chart.js": "^2.9.4",
         "jest-canvas-mock": "^2.3.0",
-        "stimulus": "^2.0.0"
+        "@hotwired/stimulus": "^3.0.0"
     },
     "jest": {
         "testRegex": "test/.*\\.test.js",

src/Chartjs/Resources/assets/src/controller.js

@@ -9,7 +9,7 @@
 
 'use strict';
 
-import { Controller } from 'stimulus';
+import { Controller } from '@hotwired/stimulus';
 import { Chart } from 'chart.js';
 
 export default class extends Controller {

src/Chartjs/Resources/assets/test/controller.test.js

@@ -9,7 +9,7 @@
 
 'use strict';
 
-import { Application, Controller } from 'stimulus';
+import { Application, Controller } from '@hotwired/stimulus';
 import { getByTestId, waitFor } from '@testing-library/dom';
 import { clearDOM, mountDOM } from '@symfony/stimulus-testing';
 import ChartjsController from '../dist/controller';

src/Chartjs/Tests/Kernel/AppKernelTrait.php

@@ -18,12 +18,12 @@
  */
 trait AppKernelTrait
 {
-    public function getCacheDir()
+    public function getCacheDir(): string
     {
         return $this->createTmpDir('cache');
     }
 
-    public function getLogDir()
+    public function getLogDir(): string
     {
         return $this->createTmpDir('logs');
     }

src/Chartjs/Tests/Kernel/EmptyAppKernel.php

@@ -24,7 +24,7 @@ class EmptyAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new ChartjsBundle()];
     }

src/Chartjs/Tests/Kernel/FrameworkAppKernel.php

@@ -26,7 +26,7 @@ class FrameworkAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new FrameworkBundle(), new ChartjsBundle()];
     }

src/Chartjs/Tests/Kernel/TwigAppKernel.php

@@ -27,7 +27,7 @@ class TwigAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new FrameworkBundle(), new TwigBundle(), new ChartjsBundle()];
     }

src/Cropperjs/CHANGELOG.md

@@ -1,7 +1,10 @@
 # CHANGELOG
 
-## 1.4
+## 2.0
 
+-   Support for `stimulus` version 2 was removed and support for `@hotwired/stimulus`
+    version 3 was added. See the [@symfony/stimulus-bridge CHANGELOG](https://github.com/symfony/stimulus-bridge/blob/main/CHANGELOG.md#300)
+    for more details.
 -   Support added for Symfony 6
 
 ## 1.3

src/Cropperjs/README.md

@@ -126,7 +126,7 @@ Symfony UX Cropper.js allows you to extend its default behavior using a custom S
 ```js
 // mycropper_controller.js
 
-import { Controller } from 'stimulus';
+import { Controller } from '@hotwired/stimulus';
 
 export default class extends Controller {
     connect() {

src/Cropperjs/Resources/assets/dist/controller.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports["default"] = void 0;
 
-var _stimulus = require("stimulus");
+var _stimulus = require("@hotwired/stimulus");
 
 var _cropperjs = _interopRequireDefault(require("cropperjs"));
 
@@ -37,7 +37,7 @@ function _possibleConstructorReturn(self, call) { if (call && (_typeof(call) ===
 
 function _assertThisInitialized(self) { if (self === void 0) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return self; }
 
-function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Date.prototype.toString.call(Reflect.construct(Date, [], function () {})); return true; } catch (e) { return false; } }
+function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
 
 function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); }
 

src/Cropperjs/Resources/assets/package.json

@@ -24,7 +24,7 @@
     },
     "peerDependencies": {
         "cropperjs": "^1.5.9",
-        "stimulus": "^2.0.0"
+        "@hotwired/stimulus": "^3.0.0"
     },
     "devDependencies": {
         "@babel/cli": "^7.12.1",
@@ -33,7 +33,7 @@
         "@babel/preset-env": "^7.12.7",
         "@symfony/stimulus-testing": "^1.1.0",
         "cropperjs": "^1.5.9",
-        "stimulus": "^2.0.0"
+        "@hotwired/stimulus": "^3.0.0"
     },
     "jest": {
         "testRegex": "test/.*\\.test.js",

src/Cropperjs/Resources/assets/src/controller.js

@@ -9,7 +9,7 @@
 
 'use strict';
 
-import { Controller } from 'stimulus';
+import { Controller } from '@hotwired/stimulus';
 import Cropper from 'cropperjs';
 
 export default class extends Controller {

src/Cropperjs/Resources/assets/test/controller.test.js

@@ -9,7 +9,7 @@
 
 'use strict';
 
-import { Application, Controller } from 'stimulus';
+import { Application, Controller } from '@hotwired/stimulus';
 import { getByTestId, waitFor } from '@testing-library/dom';
 import { clearDOM, mountDOM } from '@symfony/stimulus-testing';
 import CropperjsController from '../dist/controller';

src/Cropperjs/Tests/Kernel/AppKernelTrait.php

@@ -18,12 +18,12 @@
  */
 trait AppKernelTrait
 {
-    public function getCacheDir()
+    public function getCacheDir(): string
     {
         return $this->createTmpDir('cache');
     }
 
-    public function getLogDir()
+    public function getLogDir(): string
     {
         return $this->createTmpDir('logs');
     }

src/Cropperjs/Tests/Kernel/EmptyAppKernel.php

@@ -24,7 +24,7 @@ class EmptyAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new CropperjsBundle()];
     }

src/Cropperjs/Tests/Kernel/FrameworkAppKernel.php

@@ -26,7 +26,7 @@ class FrameworkAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new FrameworkBundle(), new CropperjsBundle()];
     }

src/Cropperjs/Tests/Kernel/TwigAppKernel.php

@@ -14,7 +14,9 @@
 use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
 use Symfony\Bundle\TwigBundle\TwigBundle;
 use Symfony\Component\Config\Loader\LoaderInterface;
+use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\Form\FormFactoryInterface;
 use Symfony\Component\HttpKernel\Kernel;
 use Symfony\UX\Cropperjs\CropperjsBundle;
 
@@ -27,7 +29,7 @@ class TwigAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new FrameworkBundle(), new TwigBundle(), new CropperjsBundle()];
     }
@@ -37,6 +39,9 @@ public function registerContainerConfiguration(LoaderInterface $loader)
         $loader->load(function (ContainerBuilder $container) {
             $container->loadFromExtension('framework', ['secret' => '$ecret', 'test' => true]);
             $container->loadFromExtension('twig', ['default_path' => __DIR__.'/templates', 'strict_variables' => true, 'exception_controller' => null]);
+
+            // create a public alias - FormFactoryInterface is removed otherwise
+            $container->setAlias('public_form_factory', new Alias(FormFactoryInterface::class, true));
         });
     }
 }

src/Dropzone/CHANGELOG.md

@@ -1,5 +1,8 @@
 # CHANGELOG
 
-## 1.4
+## 2.0
 
+-   Support for `stimulus` version 2 was removed and support for `@hotwired/stimulus`
+    version 3 was added. See the [@symfony/stimulus-bridge CHANGELOG](https://github.com/symfony/stimulus-bridge/blob/main/CHANGELOG.md#300)
+    for more details.
 -   Support added for Symfony 6

src/Dropzone/README.md

@@ -85,7 +85,7 @@ Symfony UX Dropzone allows you to extend its default behavior using a custom Sti
 ```js
 // mydropzone_controller.js
 
-import { Controller } from 'stimulus';
+import { Controller } from '@hotwired/stimulus';
 
 export default class extends Controller {
     connect() {

src/Dropzone/Resources/assets/dist/controller.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports["default"] = void 0;
 
-var _stimulus = require("stimulus");
+var _stimulus = require("@hotwired/stimulus");
 
 function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
 
@@ -33,7 +33,7 @@ function _possibleConstructorReturn(self, call) { if (call && (_typeof(call) ===
 
 function _assertThisInitialized(self) { if (self === void 0) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return self; }
 
-function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Date.prototype.toString.call(Reflect.construct(Date, [], function () {})); return true; } catch (e) { return false; } }
+function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
 
 function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); }
 

src/Dropzone/Resources/assets/package.json

@@ -22,15 +22,15 @@
         "lint": "eslint src test"
     },
     "peerDependencies": {
-        "stimulus": "^2.0.0"
+        "@hotwired/stimulus": "^3.0.0"
     },
     "devDependencies": {
         "@babel/cli": "^7.12.1",
         "@babel/core": "^7.12.3",
         "@babel/plugin-proposal-class-properties": "^7.12.1",
         "@babel/preset-env": "^7.12.7",
         "@symfony/stimulus-testing": "^1.1.0",
-        "stimulus": "^2.0.0"
+        "@hotwired/stimulus": "^3.0.0"
     },
     "jest": {
         "testRegex": "test/.*\\.test.js",

src/Dropzone/Resources/assets/src/controller.js

@@ -9,7 +9,7 @@
 
 'use strict';
 
-import { Controller } from 'stimulus';
+import { Controller } from '@hotwired/stimulus';
 
 export default class extends Controller {
     static targets = ['input', 'placeholder', 'preview', 'previewClearButton', 'previewFilename', 'previewImage'];

src/Dropzone/Resources/assets/test/controller.test.js

@@ -9,7 +9,7 @@
 
 'use strict';
 
-import { Application, Controller } from 'stimulus';
+import { Application, Controller } from '@hotwired/stimulus';
 import { getByTestId, waitFor } from '@testing-library/dom';
 import user from '@testing-library/user-event';
 import { clearDOM, mountDOM } from '@symfony/stimulus-testing';

src/Dropzone/Tests/Kernel/AppKernelTrait.php

@@ -18,12 +18,12 @@
  */
 trait AppKernelTrait
 {
-    public function getCacheDir()
+    public function getCacheDir(): string
     {
         return $this->createTmpDir('cache');
     }
 
-    public function getLogDir()
+    public function getLogDir(): string
     {
         return $this->createTmpDir('logs');
     }

src/Dropzone/Tests/Kernel/EmptyAppKernel.php

@@ -24,7 +24,7 @@ class EmptyAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new DropzoneBundle()];
     }

src/Dropzone/Tests/Kernel/FrameworkAppKernel.php

@@ -26,7 +26,7 @@ class FrameworkAppKernel extends Kernel
 {
     use AppKernelTrait;
 
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [new FrameworkBundle(), new DropzoneBundle()];
     }