Skip to content

Commit b582090

Browse files
committed
[Translator] Improve performance, replace array_reduce/array_keys by foreach
1 parent 0bf9041 commit b582090

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

src/Translator/src/TranslationsDumper.php

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -155,21 +155,18 @@ private function getTranslationsTypeScriptTypeDefinition(array $translationsByDo
155155
}
156156

157157
$parametersTypes[$domain] = $this->typeScriptMessageParametersPrinter->print($parameters);
158-
159158
$locales[] = $locale;
160159
}
161160
}
162161

162+
$typeScriptParametersType = [];
163+
foreach ($parametersTypes as $domain => $parametersType) {
164+
$typeScriptParametersType[] = \sprintf("'%s': { parameters: %s }", $domain, $parametersType);
165+
}
166+
163167
return \sprintf(
164168
'Message<{ %s }, %s>',
165-
implode(', ', array_reduce(
166-
array_keys($parametersTypes),
167-
fn (array $carry, string $domain) => [
168-
...$carry,
169-
\sprintf("'%s': { parameters: %s }", $domain, $parametersTypes[$domain]),
170-
],
171-
[],
172-
)),
169+
implode(', ', $typeScriptParametersType),
173170
implode('|', array_map(fn (string $locale) => "'$locale'", array_unique($locales))),
174171
);
175172
}

0 commit comments

Comments
 (0)