[Icons] Improve cache warmup by looking at every string

Author: kbond

src/Icons/doc/index.rst

@@ -115,6 +115,22 @@ In production, you can pre-warm the cache by running the following command:
 
 This command looks in all your twig templates for ``ux_icon`` calls and caches the icons it finds.
 
+.. caution::
+
+    Icons that have a name built dynamically will not be cached. It's advised to have the icon
+    name as a string literal in your templates.
+
+    .. code-block:: twig
+
+        {# This will be cached #}
+        {{ ux_icon('flag-fr') }}
+
+        {# This will NOT be cached #}
+        {{ ux_icon('flag-' ~ locale) }}
+
+        {% set flags = {fr: 'flag-fr', de: 'flag-de'} %} {# both "flag-fr" and "flag-de" will be cached #}
+        {{ ux_icon(flags[locale]) }}
+
 .. note::
 
     During development, if you modify an icon, you will need to clear the cache (``bin/console cache:clear``)

src/Icons/src/Command/WarmCacheCommand.php

@@ -45,7 +45,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                     $io->writeln(sprintf(' Warmed icon <comment>%s</comment>.', $name));
                 }
             },
-            onFailure: fn (string $name) => $io->warning(sprintf('Icon <comment>%s</comment> not found.', $name))
         );
 
         $io->success('Icon cache warmed.');

src/Icons/src/Twig/IconFinder.php

@@ -38,11 +38,7 @@ public function icons(): array
         foreach ($this->files($this->twig->getLoader()) as $file) {
             $contents = file_get_contents($file);
 
-            if (preg_match_all('#ux_icon\(["\']([\w:-]+)["\']#', $contents, $matches)) {
-                $found[] = $matches[1];
-            }
-
-            if (preg_match_all('#name=["\']([\w:-]+)["\']#', $contents, $matches)) {
+            if (preg_match_all('#["\']([\w:-]+)["\']#', $contents, $matches)) {
                 $found[] = $matches[1];
             }
         }

src/Icons/tests/Fixtures/templates/template2.html.twig

@@ -1,3 +1,5 @@
+{% set icon = 'flag:eu-4x3' %}
+
 {{ ux_icon('something:invalid') }}
 {{ ux_icon('invalid') }}
 {{ ux_icon('iconamoon:invalid') }}

src/Icons/tests/Integration/Command/WarmCacheCommandTest.php

@@ -29,6 +29,7 @@ public function testCanWarmCache(): void
             ->assertOutputContains('Warmed icon user.')
             ->assertOutputContains('Warmed icon sub:check.')
             ->assertOutputContains('Warmed icon iconamoon:3d-duotone.')
+            ->assertOutputContains('Warmed icon flag:eu-4x3.')
             ->assertOutputContains('Icon cache warmed.')
         ;
     }