refactor for readability

Author: bendavies

ux.symfony.com/src/Form/MealPlannerForm.php

@@ -19,6 +19,11 @@ class MealPlannerForm extends AbstractType
     public const MEAL_LUNCH = 'lunch';
     public const MEAL_DINNER = 'dinner';
 
+    /**
+     * @var array<string, mixed>
+     */
+    private $dependencies = [];
+
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $choices = [
@@ -28,43 +33,46 @@ public function buildForm(FormBuilderInterface $builder, array $options)
             'Lunch' => self::MEAL_LUNCH,
             'Dinner' => self::MEAL_DINNER,
         ];
+
         $builder->add('meal', ChoiceType::class, [
             'choices' => $choices,
             'placeholder' => 'Which meal is it?',
             'autocomplete' => true,
         ]);
 
-        $builder->addEventListener(
-            FormEvents::PRE_SET_DATA,
-            function (FormEvent $event) {
-                // the object tied to your form
-                /** @var ?MealPlan $data */
-                $data = $event->getData();
+        $builder->addEventListener(FormEvents::PRE_SET_DATA, [$this, 'onPreSetData']);
 
-                $meal = $data?->getMeal();
-                $this->addFoodField($event->getForm(), $meal);
-            }
-        );
-
-        $builder->get('meal')->addEventListener(
-            FormEvents::POST_SUBMIT,
-            function (FormEvent $event) {
-                // It's important here to fetch $event->getForm()->getData(), as
-                // $event->getData() will get you the client data (that is, the ID)
-                $meal = $event->getForm()->getData();
-
-                // since we've added the listener to the child, we'll have to pass on
-                // the parent to the callback functions!
-                $this->addFoodField($event->getForm()->getParent(), $meal);
-            }
-        );
+        $builder->get('meal')->addEventListener(FormEvents::POST_SUBMIT, [$this, 'storeDependencies']);
+        $builder->get('meal')->addEventListener(FormEvents::POST_SUBMIT, [$this, 'onPostSubmitMeal']);
     }
 
-    public function configureOptions(OptionsResolver $resolver)
+    public function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults(['data_class' => MealPlan::class]);
     }
 
+    public function onPreSetData(FormEvent $event): void
+    {
+        // the object tied to your form
+        /** @var ?MealPlan $data */
+        $data = $event->getData();
+
+        $this->addFoodField($event->getForm(), $data?->getMeal());
+    }
+
+    public function storeDependencies(FormEvent $event): void
+    {
+        $this->dependencies[$event->getForm()->getName()] = $event->getForm()->getData();
+    }
+
+    public function onPostSubmitMeal(FormEvent $event): void
+    {
+        $this->addFoodField(
+            $event->getForm()->getParent(),
+            $this->dependencies['meal'],
+        );
+    }
+
     private function getAvailableFoodChoices(string $meal): array
     {
         $foods = match ($meal) {
@@ -75,12 +83,10 @@ private function getAvailableFoodChoices(string $meal): array
             self::MEAL_DINNER => ['Pizza 🍕', 'A Pint 🍺', 'Pasta 🍝'],
         };
 
-        $foods = array_combine($foods, $foods);
-
-        return $foods;
+        return array_combine($foods, $foods);
     }
 
-    public function addFoodField(FormInterface $form, ?string $meal)
+    public function addFoodField(FormInterface $form, ?string $meal): void
     {
         $foodChoices = null === $meal ? [] : $this->getAvailableFoodChoices($meal);