Skip to content

Commit d195ee9

Browse files
committed
Rename getArrayValue
1 parent 914bcd5 commit d195ee9

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

src/LiveComponent/assets/src/live_controller.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { setDeepData, doesDeepPropertyExist, normalizeModelName, parseDeepData }
66
import { haveRenderedValuesChanged } from './have_rendered_values_changed';
77
import { normalizeAttributesForComparison } from './normalize_attributes_for_comparison';
88
import { cloneHTMLElement } from './clone_html_element';
9-
import { getArrayValue } from "./get_array_value";
9+
import { updateArrayDataFromChangedElement } from "./update_array_data";
1010

1111
interface ElementLoadingDirectives {
1212
element: HTMLElement|SVGElement,
@@ -211,7 +211,7 @@ export default class extends Controller {
211211
const { currentLevelData, finalKey } = parseDeepData(this.dataValue, normalizeModelName(model))
212212
const currentValue = currentLevelData[finalKey];
213213

214-
value = getArrayValue(element, value, currentValue);
214+
value = updateArrayDataFromChangedElement(element, value, currentValue);
215215
} else if (
216216
element instanceof HTMLInputElement
217217
&& element.type === 'checkbox'

src/LiveComponent/assets/src/get_array_value.ts renamed to src/LiveComponent/assets/src/update_array_data.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* @param value Resolved value of a single HTML element (.value or [data-value])
66
* @param currentValue Current data value
77
*/
8-
export function getArrayValue(
8+
export function updateArrayDataFromChangedElement(
99
element: HTMLElement,
1010
value: string|null,
1111
currentValue: any
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {getArrayValue} from "../src/get_array_value";
1+
import {updateArrayDataFromChangedElement} from "../src/update_array_data";
22

33

44
describe('getArrayValue', () => {
@@ -7,11 +7,11 @@ describe('getArrayValue', () => {
77
input.type = 'checkbox';
88
input.checked = true;
99

10-
expect(getArrayValue(input, 'foo', null))
10+
expect(updateArrayDataFromChangedElement(input, 'foo', null))
1111
.toEqual(['foo']);
12-
expect(getArrayValue(input, 'foo', []))
12+
expect(updateArrayDataFromChangedElement(input, 'foo', []))
1313
.toEqual(['foo']);
14-
expect(getArrayValue(input, 'foo', ['bar']))
14+
expect(updateArrayDataFromChangedElement(input, 'foo', ['bar']))
1515
.toEqual(['bar', 'foo']);
1616
})
1717

@@ -20,13 +20,13 @@ describe('getArrayValue', () => {
2020
input.type = 'checkbox';
2121
input.checked = false;
2222

23-
expect(getArrayValue(input, 'foo', null))
23+
expect(updateArrayDataFromChangedElement(input, 'foo', null))
2424
.toEqual([]);
25-
expect(getArrayValue(input, 'foo', ['foo']))
25+
expect(updateArrayDataFromChangedElement(input, 'foo', ['foo']))
2626
.toEqual([]);
27-
expect(getArrayValue(input, 'foo', ['bar']))
27+
expect(updateArrayDataFromChangedElement(input, 'foo', ['bar']))
2828
.toEqual(['bar']);
29-
expect(getArrayValue(input, 'foo', ['foo', 'bar']))
29+
expect(updateArrayDataFromChangedElement(input, 'foo', ['foo', 'bar']))
3030
.toEqual(['bar']);
3131
})
3232

@@ -40,15 +40,15 @@ describe('getArrayValue', () => {
4040
barOption.value = 'bar';
4141
select.add(barOption);
4242

43-
expect(getArrayValue(select, '', null))
43+
expect(updateArrayDataFromChangedElement(select, '', null))
4444
.toEqual([]);
4545

4646
fooOption.selected = true;
47-
expect(getArrayValue(select, '', null))
47+
expect(updateArrayDataFromChangedElement(select, '', null))
4848
.toEqual(['foo']);
4949

5050
barOption.selected = true;
51-
expect(getArrayValue(select, '', null))
51+
expect(updateArrayDataFromChangedElement(select, '', null))
5252
.toEqual(['foo', 'bar']);
5353
})
5454
});

0 commit comments

Comments
 (0)