Skip to content

Commit d81648b

Browse files
committed
[Autocomplete] Fix regression where placeholder change didn't cause a reset
1 parent 5688875 commit d81648b

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

src/Autocomplete/assets/dist/controller.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,14 @@ class default_1 extends Controller {
199199
areOptionsEquivalent(newOptions) {
200200
const filteredOriginalOptions = this.originalOptions.filter((option) => option.value !== '');
201201
const filteredNewOptions = newOptions.filter((option) => option.value !== '');
202+
const originalPlaceholderOption = this.originalOptions.find((option) => option.value === '');
203+
const newPlaceholderOption = newOptions.find((option) => option.value === '');
204+
console.log(originalPlaceholderOption, newPlaceholderOption);
205+
if (originalPlaceholderOption &&
206+
newPlaceholderOption &&
207+
originalPlaceholderOption.text !== newPlaceholderOption.text) {
208+
return false;
209+
}
202210
if (filteredOriginalOptions.length !== filteredNewOptions.length) {
203211
return false;
204212
}

src/Autocomplete/assets/src/controller.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,17 @@ export default class extends Controller {
429429
const filteredOriginalOptions = this.originalOptions.filter((option) => option.value !== '');
430430
const filteredNewOptions = newOptions.filter((option) => option.value !== '');
431431

432+
const originalPlaceholderOption = this.originalOptions.find((option) => option.value === '');
433+
const newPlaceholderOption = newOptions.find((option) => option.value === '');
434+
console.log(originalPlaceholderOption, newPlaceholderOption);
435+
if (
436+
originalPlaceholderOption &&
437+
newPlaceholderOption &&
438+
originalPlaceholderOption.text !== newPlaceholderOption.text
439+
) {
440+
return false;
441+
}
442+
432443
if (filteredOriginalOptions.length !== filteredNewOptions.length) {
433444
return false;
434445
}

0 commit comments

Comments
 (0)