Clean

Author: smnandre

src/Icons/tests/Unit/IconifyTest.php

@@ -18,7 +18,6 @@
 use Symfony\Component\HttpClient\Response\MockResponse;
 use Symfony\UX\Icons\Exception\IconNotFoundException;
 use Symfony\UX\Icons\Iconify;
-use Symfony\UX\Icons\Svg\Icon;
 
 /**
  * @author Simon André <[email protected]>
@@ -53,13 +52,7 @@ public function testFetchIcon(): void
 
     public function testFetchIconThrowsWhenIconSetDoesNotExists(): void
     {
-        $iconify = new Iconify(
-            cache: new NullAdapter(),
-            endpoint: 'https://example.com',
-            http: new MockHttpClient([
-                new JsonMockResponse([]),
-            ]),
-        );
+        $iconify = new Iconify(new NullAdapter(), 'https://example.com', new MockHttpClient(new JsonMockResponse([])));
 
         $this->expectException(IconNotFoundException::class);
         $this->expectExceptionMessage('The icon "bi:heart" does not exist on iconify.design.');
@@ -130,50 +123,21 @@ public function testGetMetadata(): void
         $this->assertSame('Font Awesome Solid', $metadata['name']);
     }
 
-    /**
-     * @dataProvider provideHttpErrors
-     */
-    public function testGetMetadataWhenHttpError(int $code, string $expectedException): void
-    {
-        $mockClient = $this->createHttpClient([], $code);
-        $iconify = new Iconify(new NullAdapter(), 'https://localhost', $mockClient);
-
-        $this->expectException($expectedException);
-
-        $iconify->metadataFor('foo');
-    }
-
     public function testFetchSvg(): void
     {
         $responseFile = __DIR__.'/../Fixtures/Iconify/icon.svg';
-        $client = new MockHttpClient(MockResponse::fromFile($responseFile));
+        $client = new MockHttpClient([
+            JsonMockResponse::fromFile(__DIR__.'/../Fixtures/Iconify/collections.json'),
+            MockResponse::fromFile($responseFile),
+        ]);
         $iconify = new Iconify(new NullAdapter(), 'https://localhost', $client);
 
-        $svg = $iconify->fetchSvg('foo', 'bar');
+        $svg = $iconify->fetchSvg('fa6-regular', 'bar');
 
         $this->assertIsString($svg);
         $this->stringContains('-.224l.235-.468ZM6.013 2.06c-.649-.1', $svg);
     }
 
-    /**
-     * @dataProvider provideHttpErrors
-     */
-    public function testFetchSvgWhenHttpError(int $code, string $expectedException): void
-    {
-        $mockClient = $this->createHttpClient([], $code);
-        $iconify = new Iconify(new NullAdapter(), 'https://localhost', $mockClient);
-
-        $this->expectException($expectedException);
-        $iconify->fetchSvg('foo', 'bar');
-    }
-
-    public static function provideHttpErrors(): iterable
-    {
-        yield [400, IconNotFoundException::class];
-        yield [404, IconNotFoundException::class];
-        yield [500, IconNotFoundException::class];
-    }
-
     private function createHttpClient(mixed $data, int $code = 200): MockHttpClient
     {
         $mockResponse = new JsonMockResponse($data, ['http_code' => $code]);