[Icons] Test Icon attributes

Author: smnandre

src/Icons/src/Svg/Icon.php

@@ -188,11 +188,6 @@ public function withAttributes(array $attributes): self
         return new self($this->innerSvg, [...$this->attributes, ...$attributes]);
     }
 
-    public function withInnerSvg(string $innerSvg): self
-    {
-        return new self($innerSvg, $this->attributes);
-    }
-
     public function __toString(): string
     {
         return $this->toHtml();

src/Icons/tests/Unit/Svg/IconTest.php

@@ -105,6 +105,25 @@ public function testInvalidIdToName(string $id)
         Icon::idToName($id);
     }
 
+    /**
+     * @dataProvider provideRenderAttributesTestCases
+     */
+    public function testRenderAttributes(array $attributes, string $expected): void
+    {
+        $icon = new Icon('', $attributes);
+        $this->assertStringStartsWith($expected, $icon->toHtml());
+    }
+
+    /**
+     * @dataProvider provideWithAttributesTestCases
+     */
+    public function testWithAttributes(array $attributes, array $withAttributes, array $expected): void
+    {
+        $icon = new Icon('foo', $attributes);
+        $icon = $icon->withAttributes($withAttributes);
+        $this->assertSame($expected, $icon->getAttributes());
+    }
+
     public static function provideIdToName(): iterable
     {
         yield from [
@@ -203,4 +222,57 @@ private static function provideInvalidIdentifiers(): iterable
             ['🙂'],
         ];
     }
+
+    public static function provideRenderAttributesTestCases(): iterable
+    {
+        yield 'it_renders_empty_attributes' => [
+            [],
+            '<svg>',
+        ];
+        yield 'it_renders_one_attribute' => [
+            ['foo' => 'bar'],
+            '<svg foo="bar">',
+        ];
+        yield 'it_renders_multiple_attributes' => [
+            ['foo' => 'bar', 'baz' => 'qux'],
+            '<svg foo="bar" baz="qux">',
+        ];
+        yield 'it_renders_true_attribute_with_no_value' => [
+            ['foo' => true],
+            '<svg foo>',
+        ];
+        yield 'it_does_not_render_attribute_with_false_value' => [
+            ['foo' => false],
+            '<svg>',
+        ];
+    }
+
+    public static function provideWithAttributesTestCases(): iterable
+    {
+        yield 'it_does_nothing_with_empty_attributes' => [
+            ['foo' => 'bar'],
+            [],
+            ['foo' => 'bar'],
+        ];
+        yield 'it_does_nothing_with_same_attributes' => [
+            ['foo' => 'bar'],
+            ['foo' => 'bar'],
+            ['foo' => 'bar'],
+        ];
+        yield 'it_does_nothing_with_same_attributes_incomplete' => [
+            ['foo' => 'bar', 'baz' => 'qux'],
+            ['foo' => 'bar'],
+            ['foo' => 'bar', 'baz' => 'qux'],
+        ];
+        yield 'it_replaces_value_with_same_key' => [
+            ['foo' => 'bar'],
+            ['foo' => 'foobar'],
+            ['foo' => 'foobar'],
+        ];
+        yield 'it_replaces_value_with_same_key_and_keep_others' => [
+            ['foo' => 'bar', 'baz' => 'qux'],
+            ['foo' => 'foobar'],
+            ['foo' => 'foobar', 'baz' => 'qux'],
+        ];
+    }
 }