Skip to content

[LiveComponent] hide property-info deprecations in Symfony 7.1 #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Apr 20, 2024

Q A
Bug fix? no
New feature? no
Issues n/a
License MIT

This fixes the LiveComponent CI on 7.1.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 20, 2024
@kbond kbond force-pushed the live/deprecation-fix branch from 1cc97a1 to 021a9ce Compare April 20, 2024 04:40
@kbond kbond requested review from smnandre and WebMamba April 22, 2024 14:09
@kbond
Copy link
Member Author

kbond commented Apr 22, 2024

Admittedly, this was mostly fixed via trial and error as I'm not too familiar with the new component. The tests pass!

Copy link
Contributor

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbond this PR make me think that we should maybe review the SymfonyUX release process. I think to fully use this PropertyInfo component we need to do more refactoring (mostly in the LiveComponentHydrator I think). And this is adding a lot if statement to use one component or an other depending of the user Symfony version, something I feel a bit wobbly... What do you think about releasing one major version each time Symfony release one new major version. So at each major version we can fully use the last Symfony major?

@kbond kbond force-pushed the live/deprecation-fix branch from 021a9ce to 60efcdf Compare April 22, 2024 18:50
@kbond kbond changed the title [LiveComponent] fix property-info deprecations in Symfony 7.1 [LiveComponent] hide property-info deprecations in Symfony 7.1 Apr 22, 2024
@kbond kbond force-pushed the live/deprecation-fix branch from 60efcdf to 7c8fef7 Compare April 22, 2024 18:53
@kbond
Copy link
Member Author

kbond commented Apr 22, 2024

I've opted to ignore these deprecations until a time I better understand the symfony/type-info component.

@kbond kbond requested a review from WebMamba April 22, 2024 18:55
@kbond kbond merged commit a93dd4d into symfony:2.x Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants