Skip to content

Make setters fluent #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Make setters fluent #45

merged 1 commit into from
Jan 7, 2021

Conversation

elkuku
Copy link
Contributor

@elkuku elkuku commented Jan 4, 2021

Q A
Bug fix? no
New feature? no
Tickets
License MIT

I just replaced some charts in a personal project with ux-chartjs and it feels quite cool ;)

To reduce local variables i'd love to see fluent setters.

wdyt?

@elkuku elkuku changed the title [Chartjs] Make setters fluent Make setters fluent Jan 4, 2021
@tgalopin
Copy link
Contributor

tgalopin commented Jan 7, 2021

Thank you @elkuku.

@tgalopin tgalopin merged commit a2dd769 into symfony:main Jan 7, 2021
@elkuku elkuku deleted the fluent-setters branch January 7, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants