Allow basic auth in url. Improve regex. Add tests.

Author: Benjamin Laugueux

Constraints/UrlValidator.php

@@ -24,6 +24,7 @@ class UrlValidator extends ConstraintValidator
 {
     const PATTERN = '~^
             (%s)://                                 # protocol
+            (([\pL\pN-]+:)?([\pL\pN-]+)@)?          # basic auth
             (
                 ([\pL\pN\pS-\.])+(\.?([\pL]|xn\-\-[\pL\pN-]+)+\.?) # a domain name
                     |                                              # or

Tests/Constraints/UrlValidatorTest.php

@@ -116,6 +116,8 @@ public function getValidUrls()
             array('http://xn--espaa-rta.xn--ca-ol-fsay5a/'),
             array('http://xn--d1abbgf6aiiy.xn--p1ai/'),
             array('http://☎.com/'),
+            array('http://username:[email protected]'),
+            array('http://[email protected]'),
         );
     }
 
@@ -155,6 +157,10 @@ public function getInvalidUrls()
             array('ftp://[::1]/'),
             array('http://[::1'),
             array('http://hello.☎/'),
+            array('http://:[email protected]'),
+            array('http://:password@@symfony.com'),
+            array('http://username:passwordsymfony.com'),
+            array('http://usern@me:[email protected]'),
         );
     }