Skip to content

Commit e4555ef

Browse files
committed
Merge branch '2.4'
* 2.4: [WIP][Finder] Fix wrong implementation on sortable callback comparator ommited space [Validator] Fixed StaticMethodLoader on systems that don't have E_STRICT enabled by default Include file path in exception [Process] Add validation on Process input Conflicts: src/Symfony/Component/Process/Process.php src/Symfony/Component/Process/ProcessBuilder.php src/Symfony/Component/Process/Tests/ProcessBuilderTest.php
2 parents da6272c + acea95c commit e4555ef

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

Resources/translations/validators.id.xlf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164
</trans-unit>
165165
<trans-unit id="44">
166166
<source>The image width is too small ({{ width }}px). Minimum width expected is {{ min_width }}px.</source>
167-
<target>Lebar gambar terlalu kecil ({{ width}}px). Ukuran lebar minimum yang diharapkan adalah {{ min_width }}px.</target>
167+
<target>Lebar gambar terlalu kecil ({{ width }}px). Ukuran lebar minimum yang diharapkan adalah {{ min_width }}px.</target>
168168
</trans-unit>
169169
<trans-unit id="45">
170170
<source>The image height is too big ({{ height }}px). Allowed maximum height is {{ max_height }}px.</source>

Tests/Mapping/Loader/StaticMethodLoaderTest.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,18 @@
1717

1818
class StaticMethodLoaderTest extends \PHPUnit_Framework_TestCase
1919
{
20+
private $errorLevel;
21+
22+
protected function setUp()
23+
{
24+
$this->errorLevel = error_reporting();
25+
}
26+
27+
protected function tearDown()
28+
{
29+
error_reporting($this->errorLevel);
30+
}
31+
2032
public function testLoadClassMetadataReturnsTrueIfSuccessful()
2133
{
2234
$loader = new StaticMethodLoader('loadMetadata');
@@ -78,6 +90,8 @@ public function testLoadClassMetadataInAbstractClasses()
7890

7991
public function testLoadClassMetadataIgnoresAbstractMethods()
8092
{
93+
error_reporting(E_ALL | E_STRICT);
94+
8195
$loader = new StaticMethodLoader('loadMetadata');
8296
$caught = false;
8397
try {

0 commit comments

Comments
 (0)