minor #20101 Simplified link-to-source mapping definitions in debug.file_link_format (nicolas-grekas)

This PR was merged into the 3.2-dev branch.

Discussion
----------

Simplified link-to-source mapping definitions in debug.file_link_format

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19950
| License       | MIT
| Doc PR        | symfony/symfony-docs#7019

Having to json_encode here (or any other kind of encoding) is really tedious to deal with: it makes it hard to have things working quickly. `%f` and `%l` aren't encoded anyway, so let's use very unlikely chars as separators here also instead.

Commits
-------

27df38e Simplified link-to-source mapping definitions in debug.file_link_format

Author: fabpot

Dumper/HtmlDumper.php

@@ -542,16 +542,12 @@ private function getSourceLink($file, $line)
             return false;
         }
         if (!is_array($fileLinkFormat)) {
-            $i = max(strpos($fileLinkFormat, '%f'), strpos($fileLinkFormat, '%l'));
-            $i = strpos($fileLinkFormat, '#"', $i) ?: strlen($fileLinkFormat);
-            $fileLinkFormat = array(substr($fileLinkFormat, 0, $i), substr($fileLinkFormat, $i + 1));
-            $fileLinkFormat[1] = @json_decode('{'.$fileLinkFormat[1].'}', true) ?: array();
-            $this->extraDisplayOptions['fileLinkFormat'] = $fileLinkFormat;
+            $i = strpos($f = $fileLinkFormat, '&', max(strrpos($f, '%f'), strrpos($f, '%l'))) ?: strlen($f);
+            $fileLinkFormat = array(substr($f, 0, $i)) + preg_split('/&([^>]++)>/', substr($f, $i), -1, PREG_SPLIT_DELIM_CAPTURE);
         }
-
-        foreach ($fileLinkFormat[1] as $k => $v) {
-            if (0 === strpos($file, $k)) {
-                $file = substr_replace($file, $v, 0, strlen($k));
+        for ($i = 1; isset($fileLinkFormat[$i]); ++$i) {
+            if (0 === strpos($file, $k = $fileLinkFormat[$i++])) {
+                $file = substr_replace($file, $fileLinkFormat[$i], 0, strlen($k));
                 break;
             }
         }