Skip to content

Commit af0e386

Browse files
[EventDispatcher] swap arguments of dispatch() to allow registering events by FQCN
1 parent aaecd72 commit af0e386

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

EventListener/AddLinkHeaderListener.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
use Psr\Link\LinkProviderInterface;
1515
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
16-
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
16+
use Symfony\Component\HttpKernel\Event\ResponseEvent;
1717
use Symfony\Component\HttpKernel\KernelEvents;
1818
use Symfony\Component\WebLink\HttpHeaderSerializer;
1919

@@ -33,7 +33,7 @@ public function __construct()
3333
$this->serializer = new HttpHeaderSerializer();
3434
}
3535

36-
public function onKernelResponse(FilterResponseEvent $event)
36+
public function onKernelResponse(ResponseEvent $event)
3737
{
3838
if (!$event->isMasterRequest()) {
3939
return;

Tests/EventListener/AddLinkHeaderListenerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
1818
use Symfony\Component\HttpFoundation\Request;
1919
use Symfony\Component\HttpFoundation\Response;
20-
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
20+
use Symfony\Component\HttpKernel\Event\ResponseEvent;
2121
use Symfony\Component\HttpKernel\KernelEvents;
2222
use Symfony\Component\WebLink\EventListener\AddLinkHeaderListener;
2323

@@ -33,7 +33,7 @@ public function testOnKernelResponse()
3333

3434
$subscriber = new AddLinkHeaderListener();
3535

36-
$event = $this->getMockBuilder(FilterResponseEvent::class)->disableOriginalConstructor()->getMock();
36+
$event = $this->getMockBuilder(ResponseEvent::class)->disableOriginalConstructor()->getMock();
3737
$event->method('isMasterRequest')->willReturn(true);
3838
$event->method('getRequest')->willReturn($request);
3939
$event->method('getResponse')->willReturn($response);

composer.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@
2424
"symfony/http-kernel": ""
2525
},
2626
"require-dev": {
27-
"symfony/event-dispatcher": "~3.4|~4.0",
2827
"symfony/http-foundation": "~3.4|~4.0",
29-
"symfony/http-kernel": "~3.4|~4.0"
28+
"symfony/http-kernel": "^4.3"
29+
},
30+
"conflict": {
31+
"symfony/http-kernel": "<4.3"
3032
},
3133
"autoload": {
3234
"psr-4": { "Symfony\\Component\\WebLink\\": "" },

0 commit comments

Comments
 (0)