fixed public directory of web server and assets install when configured in composer.json

Author: alexander-schranz

DependencyInjection/WebServerExtension.php

@@ -27,8 +27,31 @@ public function load(array $configs, ContainerBuilder $container)
         $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('webserver.xml');
 
+        $publicDirectory = $this->getPublicDirectory($container);
+        $container->getDefinition('web_server.command.server_run')->replaceArgument(0, $publicDirectory);
+        $container->getDefinition('web_server.command.server_start')->replaceArgument(0, $publicDirectory);
+
         if (!class_exists(ConsoleFormatter::class)) {
             $container->removeDefinition('web_server.command.server_log');
         }
     }
+
+    private function getPublicDirectory(ContainerBuilder $container)
+    {
+        $kernelProjectDir = $container->getParameter('kernel.project_dir');
+        $publicDir = 'public';
+        $composerFilePath = $kernelProjectDir.'/composer.json';
+
+        if (!file_exists($composerFilePath)) {
+            return $kernelProjectDir.'/'.$publicDir;
+        }
+
+        $composerConfig = json_decode(file_get_contents($composerFilePath), true);
+
+        if (isset($composerConfig['extra']['public-dir'])) {
+            $publicDir = $composerConfig['extra']['public-dir'];
+        }
+
+        return $kernelProjectDir.'/'.$publicDir;
+    }
 }

Tests/DependencyInjection/WebServerExtensionTest.php

@@ -21,8 +21,17 @@ class WebServerExtensionTest extends TestCase
     public function testLoad()
     {
         $container = new ContainerBuilder();
+        $container->setParameter('kernel.project_dir', __DIR__);
         (new WebServerExtension())->load(array(), $container);
 
+        $this->assertSame(
+            __DIR__.'/test',
+            $container->getDefinition('web_server.command.server_run')->getArgument(0)
+        );
+        $this->assertSame(
+            __DIR__.'/test',
+            $container->getDefinition('web_server.command.server_start')->getArgument(0)
+        );
         $this->assertTrue($container->hasDefinition('web_server.command.server_run'));
         $this->assertTrue($container->hasDefinition('web_server.command.server_start'));
         $this->assertTrue($container->hasDefinition('web_server.command.server_stop'));

Tests/DependencyInjection/composer.json

@@ -0,0 +1,6 @@
+{
+    "name": "test-composer.json",
+    "extra": {
+        "public-dir": "test"
+    }
+}