Allow disabling default build if multiple entry points are defined

Author: emodric

README.md

@@ -22,6 +22,8 @@ file:
 webpack_encore:
     # The path where Encore is building the assets - i.e. Encore.setOutputPath()
     output_path: '%kernel.public_dir%/build'
+    # If multiple builds are defined (as shown below), you can disable the default build:
+    # output_path: false
 
     # if you have multiple builds:
     # builds:

src/DependencyInjection/Configuration.php

@@ -23,6 +23,12 @@ public function getConfigTreeBuilder()
         $rootNode = method_exists($treeBuilder, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root('webpack_encore');
 
         $rootNode
+            ->validate()
+                ->ifTrue(function (array $v): bool {
+                    return false === $v['output_path'] && empty($v['builds']);
+                })
+                ->thenInvalid('Default build can only be disabled if multiple entry points are defined.')
+            ->end()
             ->children()
                 ->scalarNode('output_path')
                     ->isRequired()

src/DependencyInjection/WebpackEncoreExtension.php

@@ -28,15 +28,16 @@ public function load(array $configs, ContainerBuilder $container)
         $configuration = $this->getConfiguration($configs, $container);
         $config = $this->processConfiguration($configuration, $configs);
 
-        $factories = [
-            '_default' => new Reference($this->entrypointFactory($container, '_default', $config['output_path']))
-        ];
+        $factories = [];
+
+        if ($config['output_path'] !== false) {
+            $factories['_default'] = new Reference($this->entrypointFactory($container, '_default', $config['output_path']));
+        }
+
         foreach ($config['builds'] as $name => $path) {
             $factories[$name] = new Reference($this->entrypointFactory($container, $name, $path));
-        };
+        }
 
-        $container->getDefinition('webpack_encore.entrypoint_lookup')
-            ->replaceArgument(0, $factories['_default']);
         $container->getDefinition('webpack_encore.entrypoint_lookup_collection')
             ->replaceArgument(0, ServiceLocatorTagPass::register($container, $factories));
     }

src/Resources/config/services.xml

@@ -7,9 +7,6 @@
     <services>
         <defaults public="false" />
 
-        <service id="webpack_encore.entrypoint_lookup" class="Symfony\WebpackEncoreBundle\Asset\EntrypointLookup">
-            <argument /> <!-- entrypoints.json path -->
-        </service>
         <service id="webpack_encore.entrypoint_lookup_collection" class="Symfony\WebpackEncoreBundle\Asset\EntrypointLookupCollection">
             <argument /> <!-- build list of entrypoints path -->
         </service>
@@ -25,7 +22,6 @@
                 <service class="Symfony\Component\DependencyInjection\ServiceLocator">
                     <tag name="container.service_locator" />
                     <argument type="collection">
-                        <argument key="webpack_encore.entrypoint_lookup" type="service" id="webpack_encore.entrypoint_lookup" />
                         <argument key="webpack_encore.entrypoint_lookup_collection" type="service" id="webpack_encore.entrypoint_lookup_collection" />
                         <argument key="webpack_encore.tag_renderer" type="service" id="webpack_encore.tag_renderer" />
                     </argument>