Do not JSON encode stringable values

jderusse · jderusse · commit 23d4d6049e21 · 2022-04-21T11:52:12.000+02:00
diff --git a/src/Twig/StimulusTwigExtension.php b/src/Twig/StimulusTwigExtension.php
@@ -61,11 +61,11 @@ public function renderStimulusController(Environment $env, $dataOrControllerName
                     continue;
                 }
 
-                if (!is_scalar($value)) {
+                if ($value instanceof \Stringable || (is_object($value) && \is_callable([$value, '__toString']))) {
+                    $value = (string) $value;
+                } elseif (!is_scalar($value)) {
                     $value = json_encode($value);
-                }
-
-                if (\is_bool($value)) {
+                } elseif (\is_bool($value)) {
                     $value = $value ? 'true' : 'false';
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -61,11 +61,11 @@ public function renderStimulusController(Environment $env, $dataOrControllerName`
`61`	`61`	`continue;`
`62`	`62`	`}`
`63`	`63`
`64`		`- if (!is_scalar($value)) {`
	`64`	`+ if ($value instanceof \Stringable \|\| (is_object($value) && \is_callable([$value, '__toString']))) {`
	`65`	`+ $value = (string) $value;`
	`66`	`+ } elseif (!is_scalar($value)) {`
`65`	`67`	`$value = json_encode($value);`
`66`		`- }`
`67`		`-`
`68`		`- if (\is_bool($value)) {`
	`68`	`+ } elseif (\is_bool($value)) {`
`69`	`69`	`$value = $value ? 'true' : 'false';`
`70`	`70`	`}`
`71`	`71`