bug #50 integration test created for cache warmer (codayblue)

This PR was merged into the master branch.

Discussion
----------

integration test created for cache warmer

- Created integration test
- Created an alias so that cash warmer could be autowired
- Fixed a bug where entrypoints.json was not added to the path so the exception would get thrown that entry point was missing

Commits
-------

ef7c34d integration test created for cache warmer

Author: weaverryan

src/DependencyInjection/WebpackEncoreExtension.php

@@ -36,7 +36,7 @@ public function load(array $configs, ContainerBuilder $container)
         ];
         foreach ($config['builds'] as $name => $path) {
             $factories[$name] = $this->entrypointFactory($container, $name, $path, $config['cache']);
-            $cacheKeys[rawurlencode($name)] = $path;
+            $cacheKeys[rawurlencode($name)] = $path.'/entrypoints.json';
         }
 
         $container->getDefinition('webpack_encore.entrypoint_lookup.cache_warmer')

src/Resources/config/services.xml

@@ -36,6 +36,8 @@
             <argument type="service" id="cache.webpack_encore" />
         </service>
 
+        <service id="Symfony\WebpackEncoreBundle\CacheWarmer\EntrypointCacheWarmer" alias="webpack_encore.entrypoint_lookup.cache_warmer" />
+
         <service id="webpack_encore.cache" class="Symfony\Component\Cache\Adapter\PhpArrayAdapter">
             <factory class="Symfony\Component\Cache\Adapter\PhpArrayAdapter" method="create" />
             <argument>%kernel.cache_dir%/webpack_encore.cache.php</argument>

tests/IntegrationTest.php

@@ -2,6 +2,7 @@
 
 namespace Symfony\WebpackEncoreBundle\Tests;
 
+use Symfony\WebpackEncoreBundle\CacheWarmer\EntrypointCacheWarmer;
 use Symfony\WebpackEncoreBundle\WebpackEncoreBundle;
 use PHPUnit\Framework\TestCase;
 use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
@@ -77,6 +78,19 @@ public function testEntriesAreNotRepeteadWhenAlreadyOutputIntegration()
             $html2
         );
     }
+
+    public function testCacheWarmer()
+    {
+        $kernal = new WebpackEncoreIntegrationTestKernel(true);
+        $kernal->boot();
+        $container = $kernal->getContainer();
+
+        $cacheWarmer = $container->get(CacheWarmerTester::class);
+
+        $cacheWarmer->warmCache($kernal->getCacheDir());
+
+        $this->assertTrue(true, 'Cache warmer has successfully filled that cache and went without exceptions');
+    }
 }
 
 class WebpackEncoreIntegrationTestKernel extends Kernel
@@ -117,11 +131,13 @@ public function registerContainerConfiguration(LoaderInterface $loader)
 
             $container->loadFromExtension('webpack_encore', [
                 'output_path' => __DIR__.'/fixtures/build',
-                'cache' => false,
+                'cache' => true,
                 'builds' => [
                     'different_build' =>  __DIR__.'/fixtures/different_build'
                 ]
             ]);
+
+            $container->autowire(CacheWarmerTester::class)->setPublic(true);
         });
     }
 
@@ -135,3 +151,18 @@ public function getLogDir()
         return sys_get_temp_dir().'/logs'.spl_object_hash($this);
     }
 }
+
+class CacheWarmerTester
+{
+    private $entrypointCacheWarmer;
+
+    public function __construct(EntrypointCacheWarmer $entrypointCacheWarmer)
+    {
+        $this->entrypointCacheWarmer = $entrypointCacheWarmer;
+    }
+
+    public function warmCache(string $cacheDir)
+    {
+        $this->entrypointCacheWarmer->warmUp($cacheDir);
+    }
+}