Skip to content

Commit 08509da

Browse files
committed
removing vue3 and jsx support for now
1 parent c344809 commit 08509da

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

fixtures/vuejs-jsx/main_v3.js

Lines changed: 0 additions & 4 deletions
This file was deleted.

lib/WebpackConfig.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -760,6 +760,11 @@ class WebpackConfig {
760760

761761
this.vueOptions[key] = vueOptions[key];
762762
}
763+
764+
// useJsx and vue 3 are not currently supported by Encore
765+
if (this.vueOptions.useJsx && this.vueOptions.version === 3) {
766+
throw new Error('Setting both "useJsx: true" and "version: 3" for enableVueLoader() is not currently supported. Please use version: 2 or disable useJsx.');
767+
}
763768
}
764769

765770
enableEslintLoader(eslintLoaderOptionsOrCallback = () => {}, eslintOptions = {}) {

test/functional.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1834,7 +1834,7 @@ module.exports = {
18341834
}, true);
18351835
});
18361836

1837-
it('Vue.js is compiled correctly with JSX support', (done) => {
1837+
it('Vue.js is compiled correctly with JSX support', function(done) {
18381838
const appDir = testSetup.createTestAppDir();
18391839

18401840
fs.writeFileSync(
@@ -1848,6 +1848,14 @@ module.exports = {
18481848
);
18491849

18501850
const config = testSetup.createWebpackConfig(appDir, 'www/build', 'dev');
1851+
1852+
if (getVueVersion(config) === 3) {
1853+
// not supported for vue3 at this time
1854+
this.skip();
1855+
1856+
return;
1857+
}
1858+
18511859
config.enableSingleRuntimeChunk();
18521860
config.setPublicPath('/build');
18531861
config.addEntry('main', `./vuejs-jsx/main_v${getVueVersion(config)}`);

0 commit comments

Comments
 (0)