Skip to content

Commit 35e508f

Browse files
committed
Forcing vue installation to include @3 or @2 version constraint on yarn add command
1 parent d49352b commit 35e508f

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

lib/features.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ const features = {
9292
// vue is needed so the end-user can do things
9393
// vue-template-compiler is a peer dep of vue-loader
9494
packages: [
95-
{ name: 'vue' },
96-
{ name: 'vue-loader', enforce_version: true },
95+
{ name: 'vue', version: '^2' },
96+
{ name: 'vue-loader', version: '^15' },
9797
{ name: 'vue-template-compiler' }
9898
],
9999
description: 'load Vue files'
@@ -103,7 +103,7 @@ const features = {
103103
// vue is needed so the end-user can do things
104104
// @vue/compiler-sfc is an optional peer dep of vue-loader
105105
packages: [
106-
{ name: 'vue' },
106+
{ name: 'vue', enforce_version: true },
107107
{ name: 'vue-loader', enforce_version: true },
108108
{ name: '@vue/compiler-sfc' }
109109
],

test/package-helper.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,8 @@ describe('package-helper', () => {
165165
it('Lookup a version constraint', () => {
166166
const inputPackages = [
167167
{ name: 'sass-loader', enforce_version: 7 },
168-
{ name: 'node-sass' }
168+
{ name: 'node-sass' },
169+
{ name: 'vue', version: '^2'}
169170
];
170171

171172
const packageInfo = JSON.parse(
@@ -174,7 +175,8 @@ describe('package-helper', () => {
174175

175176
const expectedPackages = [
176177
{ name: 'sass-loader', version: packageInfo.devDependencies['sass-loader'] },
177-
{ name: 'node-sass' }
178+
{ name: 'node-sass' },
179+
{ name: 'vue', version: '^2' }
178180
];
179181

180182
const actualPackages = packageHelper.addPackagesVersionConstraint(inputPackages);

0 commit comments

Comments
 (0)