moving tests from config-generator to babel.js

Author: weaverryan

test/config-generator.js

@@ -375,57 +375,6 @@ describe('The config-generator function', () => {
             // check for the default env preset only
             expect(JSON.stringify(jsRule.use[0].options.presets)).contains('env');
         });
-
-        it('If .babelrc is present, we pass *no* config', () => {
-            const runtimeConfig = new RuntimeConfig();
-            runtimeConfig.babelRcFileExists = true;
-            const config = createConfig(runtimeConfig);
-            config.outputPath = '/tmp/output/public-path';
-            config.publicPath = '/public-path';
-            config.addEntry('main', './main');
-
-            const actualConfig = configGenerator(config);
-
-            const jsRule = findRule(/\.jsx?$/, actualConfig.module.rules);
-
-            // the options should only contain the cacheDirectory option
-            expect(JSON.stringify(jsRule.use[0].options)).to.equal(JSON.stringify({ 'cacheDirectory': true }));
-        });
-
-        it('configureBabel() passes babel options', () => {
-            const config = createConfig();
-            config.outputPath = '/tmp/output/public-path';
-            config.publicPath = '/public-path';
-            config.addEntry('main', './main');
-            config.configureBabel(function(babelConfig) {
-                babelConfig.presets.push('foo');
-            });
-
-            const actualConfig = configGenerator(config);
-
-            const jsRule = findRule(/\.jsx?$/, actualConfig.module.rules);
-
-            expect(jsRule.use[0].options.presets).to.include('foo');
-        });
-
-        it('enableReactPreset() passes react preset to babel', () => {
-            const config = createConfig();
-            config.outputPath = '/tmp/output/public-path';
-            config.publicPath = '/public-path';
-            config.addEntry('main', './main');
-            config.enableReactPreset();
-            config.configureBabel(function(babelConfig) {
-                babelConfig.presets.push('foo');
-            });
-
-            const actualConfig = configGenerator(config);
-
-            const jsRule = findRule(/\.jsx?$/, actualConfig.module.rules);
-
-            expect(jsRule.use[0].options.presets).to.include('react');
-            // foo is also still there, not overridden
-            expect(jsRule.use[0].options.presets).to.include('foo');
-        });
     });
 
     describe('cleanupOutputBeforeBuild() adds CleanWebpackPlugin', () => {

test/loaders/babel.js

@@ -0,0 +1,68 @@
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+'use strict';
+
+const expect = require('chai').expect;
+const WebpackConfig = require('../../lib/WebpackConfig');
+const RuntimeConfig = require('../../lib/config/RuntimeConfig');
+const babelLoader = require('../../lib/loaders/babel');
+
+function createConfig() {
+    const runtimeConfig = new RuntimeConfig();
+    runtimeConfig.context = __dirname;
+    runtimeConfig.babelRcFileExists = false;
+
+    return new WebpackConfig(runtimeConfig);
+}
+
+describe('loaders/babel', () => {
+    it('getLoaders() basic usage', () => {
+        const config = createConfig();
+        config.runtimeConfig.babelRcFileExists = false;
+        config.configureBabel(function(config) {
+            config.foo = 'bar';
+        });
+
+        const actualLoaders = babelLoader.getLoaders(config);
+        expect(actualLoaders).to.have.lengthOf(1);
+        // the env preset is enabled by default
+        expect(actualLoaders[0].options.presets).to.have.lengthOf(1);
+        // callback is used
+        expect(actualLoaders[0].options.foo).to.equal('bar');
+    });
+
+    it('getLoaders() when .babelrc IS present', () => {
+        const config = createConfig();
+        config.runtimeConfig.babelRcFileExists = true;
+
+        const actualLoaders = babelLoader.getLoaders(config);
+        // we only add cacheDirectory
+        expect(actualLoaders[0].options).to.deep.equal({
+            cacheDirectory: true
+        });
+    });
+
+    it('getLoaders() with react', () => {
+        const config = createConfig();
+        config.enableReactPreset();
+
+        config.configureBabel(function(babelConfig) {
+            babelConfig.presets.push('foo');
+        });
+
+        const actualLoaders = babelLoader.getLoaders(config);
+
+        // env, react & foo
+        expect(actualLoaders[0].options.presets).to.have.lengthOf(3);
+        expect(actualLoaders[0].options.presets).to.include('react');
+        // foo is also still there, not overridden
+        expect(actualLoaders[0].options.presets).to.include('foo');
+    });
+});