Skip to content

Commit 605c760

Browse files
committed
feature #763 Removing vue2 alias to use the full build (weaverryan)
This PR was merged into the master branch. Discussion ---------- Removing vue2 alias to use the full build Fixes #674 Commits ------- bece20e removing vue2 alias to use the full build
2 parents cd661d3 + bece20e commit 605c760

File tree

2 files changed

+24
-8
lines changed

2 files changed

+24
-8
lines changed

CHANGELOG.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,28 @@
22

33
## 0.30.0
44

5+
* [BC BREAK] The Vue "build" was changed from `vue.esm.js` (full build) to
6+
`vue.runtime.esm.js` (runtime build). With the runtime build, there are
7+
two things that you cannot do:
8+
9+
A) You cannot pass a string to `template`:
10+
11+
```js
12+
new Vue({
13+
template: '<div>{{ hi }}</div>'
14+
})
15+
```
16+
17+
B) You cannot mount to a DOM element and use its HTML as your template:
18+
19+
```js
20+
new Vue({
21+
el: '#app', // where <div id="app"> contains your Vue template
22+
});
23+
```
24+
25+
If you need this behavior, call `Encore.addAliases({ vue$: 'vue/dist/vue.esm.js' });`
26+
527
* [DEPENDENCY UPGRADE] `sass-loader` was upgraded from version 7 to 8.
628
See the [CHANGELOG](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md#800-2019-08-29)
729
for breaking changes. This likely will not affect you unless pass
@@ -38,6 +60,8 @@
3860
thanks to @jdreesen.
3961

4062
* [DEPENDENCY UPGRADE] The `fork-ts-checker-webpack-plugin` package was upgraded for the tests
63+
64+
* The `fork-ts-checker-webpack-plugin` package was upgraded for the tests
4165
from `^0.4.1` to `^4.0.0`. If you're using `enableForkedTypeScriptTypesChecking()`,
4266
you control the `fork-ts-checker-webpack-plugin` version in your
4367
`package.json` file. You should upgrade to `^4.0.0` to ensure

lib/config-generator.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ const PluginPriorities = require('./plugins/plugin-priorities');
4343
const applyOptionsCallback = require('./utils/apply-options-callback');
4444
const sharedEntryTmpName = require('./utils/sharedEntryTmpName');
4545
const copyEntryTmpName = require('./utils/copyEntryTmpName');
46-
const getVueVersion = require('./utils/get-vue-version');
4746
const tmp = require('tmp');
4847
const fs = require('fs');
4948
const path = require('path');
@@ -101,13 +100,6 @@ class ConfigGenerator {
101100
alias: {}
102101
};
103102

104-
if (this.webpackConfig.useVueLoader) {
105-
const vueVersion = getVueVersion(this.webpackConfig);
106-
if (vueVersion === 2) {
107-
config.resolve.alias['vue$'] = 'vue/dist/vue.esm.js';
108-
}
109-
}
110-
111103
if (this.webpackConfig.usePreact && this.webpackConfig.preactOptions.preactCompat) {
112104
config.resolve.alias['react'] = 'preact-compat';
113105
config.resolve.alias['react-dom'] = 'preact-compat';

0 commit comments

Comments
 (0)