Skip to content

Commit 8598b07

Browse files
committed
test: fix define plugin definitions format
1 parent cc9c9d0 commit 8598b07

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

test/config-generator.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ describe('The config-generator function', () => {
225225
const actualConfig = configGenerator(config);
226226

227227
const definePlugin = findPlugin(webpack.DefinePlugin, actualConfig.plugins);
228-
expect(definePlugin.definitions['process.env'].NODE_ENV).to.equal('"development"');
228+
expect(definePlugin.definitions['process.env.NODE_ENV']).to.equal('"development"');
229229

230230
expect(actualConfig.optimization.minimizer).to.be.undefined;
231231
});
@@ -241,7 +241,7 @@ describe('The config-generator function', () => {
241241
const actualConfig = configGenerator(config);
242242

243243
const definePlugin = findPlugin(webpack.DefinePlugin, actualConfig.plugins);
244-
expect(definePlugin.definitions['process.env'].NODE_ENV).to.equal('"production"');
244+
expect(definePlugin.definitions['process.env.NODE_ENV']).to.equal('"production"');
245245

246246
expect(actualConfig.optimization.minimizer[0]).to.not.be.undefined;
247247
});

test/plugins/define.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe('plugins/define', () => {
3232
definePluginUtil(plugins, config);
3333
expect(plugins.length).to.equal(1);
3434
expect(plugins[0].plugin).to.be.instanceof(webpack.DefinePlugin);
35-
expect(plugins[0].plugin.definitions['process.env'].NODE_ENV).to.equal(JSON.stringify('development'));
35+
expect(plugins[0].plugin.definitions['process.env.NODE_ENV']).to.equal(JSON.stringify('development'));
3636
});
3737

3838
it('production environment with default settings', () => {
@@ -42,7 +42,7 @@ describe('plugins/define', () => {
4242
definePluginUtil(plugins, config);
4343
expect(plugins.length).to.equal(1);
4444
expect(plugins[0].plugin).to.be.instanceof(webpack.DefinePlugin);
45-
expect(plugins[0].plugin.definitions['process.env'].NODE_ENV).to.equal(JSON.stringify('production'));
45+
expect(plugins[0].plugin.definitions['process.env.NODE_ENV']).to.equal(JSON.stringify('production'));
4646
});
4747

4848
it('production environment with options callback', () => {
@@ -60,10 +60,10 @@ describe('plugins/define', () => {
6060

6161
// Allows to add new definitions
6262
expect(plugins[0].plugin.definitions.foo).to.equal(true);
63-
expect(plugins[0].plugin.definitions['process.env'].bar).to.equal(true);
63+
expect(plugins[0].plugin.definitions['process.env.bar']).to.equal(true);
6464

6565
// Doesn't remove default definitions
66-
expect(plugins[0].plugin.definitions['process.env'].NODE_ENV).to.equal(JSON.stringify('production'));
66+
expect(plugins[0].plugin.definitions['process.env.NODE_ENV']).to.equal(JSON.stringify('production'));
6767
});
6868

6969
it('production environment with options callback that returns an object', () => {

0 commit comments

Comments
 (0)