Skip to content

Commit af97208

Browse files
committed
removing vue2 alias to use the full build
1 parent 77008f2 commit af97208

File tree

2 files changed

+19
-8
lines changed

2 files changed

+19
-8
lines changed

CHANGELOG.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,25 @@
22

33
## 0.30.0
44

5+
* [BC BREAK] The Vue "build" was changed from `vue.esm.js` (full build) to
6+
`vue.runtime.esm.js` (runtime build). With the runtime build, there are
7+
two things that you cannot do:
8+
9+
A) You cannot pass a string to `template`:
10+
11+
```js
12+
```
13+
14+
B) You cannot mount to a DOM element and use its HTML as your template:
15+
16+
```js
17+
new Vue({
18+
el: '#app', // where <div id="app"> contains your Vue template
19+
});
20+
```
21+
22+
If you need this behavior, call `Encore.addAliases({ vue$: 'vue/dist/vue.esm.js' });`
23+
524
* The `fork-ts-checker-webpack-plugin` package was upgraded for the tests
625
from `^0.4.1` to `^4.0.0`. If you're using `enableForkedTypeScriptTypesChecking()`,
726
you control the `fork-ts-checker-webpack-plugin` version in your

lib/config-generator.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ const PluginPriorities = require('./plugins/plugin-priorities');
4343
const applyOptionsCallback = require('./utils/apply-options-callback');
4444
const sharedEntryTmpName = require('./utils/sharedEntryTmpName');
4545
const copyEntryTmpName = require('./utils/copyEntryTmpName');
46-
const getVueVersion = require('./utils/get-vue-version');
4746
const tmp = require('tmp');
4847
const fs = require('fs');
4948
const path = require('path');
@@ -101,13 +100,6 @@ class ConfigGenerator {
101100
alias: {}
102101
};
103102

104-
if (this.webpackConfig.useVueLoader) {
105-
const vueVersion = getVueVersion(this.webpackConfig);
106-
if (vueVersion === 2) {
107-
config.resolve.alias['vue$'] = 'vue/dist/vue.esm.js';
108-
}
109-
}
110-
111103
if (this.webpackConfig.usePreact && this.webpackConfig.preactOptions.preactCompat) {
112104
config.resolve.alias['react'] = 'preact-compat';
113105
config.resolve.alias['react-dom'] = 'preact-compat';

0 commit comments

Comments
 (0)