Skip to content

Commit eb559f0

Browse files
committed
feature #870 Prefer sass over node-sass (weaverryan)
This PR was merged into the main branch. Discussion ---------- Prefer sass over node-sass This will change the recommendation to `sass` instead of `node-sass` which is deprecated and harder to deal with. I haven't had any issues or differences working with `sass` yet vs `node-sass`. I also upgraded the lock file in general, it makes it easier to see what packages are legitimately out of date and doesn't affect end users. Commits ------- aec475d prefer sass over node-sass
2 parents 30f84e1 + aec475d commit eb559f0

File tree

3 files changed

+25
-487
lines changed

3 files changed

+25
-487
lines changed

lib/features.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const features = {
2121
packages: [
2222
{ name: 'sass-loader', enforce_version: true },
2323
// allow node-sass or sass to be installed
24-
[{ name: 'node-sass' }, { name: 'sass' }]
24+
[{ name: 'sass' }, { name: 'node-sass' }]
2525
],
2626
description: 'load Sass files'
2727
},

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@
8585
"less": "^3.11.3",
8686
"less-loader": "^6.2.0",
8787
"mocha": "^7.1.2",
88-
"node-sass": "^4.5.3",
8988
"postcss-loader": "^4.0.0",
9089
"preact": "^8.2.1",
9190
"preact-compat": "^3.17.0",

0 commit comments

Comments
 (0)