Display a warning when calling "copyFiles" with an invalid path #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Nov 16, 2018
lib/config-generator.js
Outdated
| ); | ||
|
|
||
| if (!fs.existsSync(copyFrom) || !fs.lstatSync(copyFrom).isDirectory()) { | ||
| logger.warning(`The "from" option of copyFiles() should be set to an existing directory but "${entry.from}" does not seem to be one. No file will be copied for this entry.`); |
There was a problem hiding this comment.
"entry" might not be the best word here... because it means something else
There was a problem hiding this comment.
Hmmm, maybe... by "entry" I meant "config entry", would it be better to put that?
weaverryan
reviewed
Nov 16, 2018
lib/config-generator.js
Outdated
| entry.from | ||
| ); | ||
|
|
||
| if (!fs.existsSync(copyFrom) || !fs.lstatSync(copyFrom).isDirectory()) { |
There was a problem hiding this comment.
I guess we could break these into 2 separate pieces: 1 error is that the path doesn't exist. Another error is that they've pointed directly to a single file, not a directory, right?
…rectory or an invalid one
weaverryan
approved these changes
Nov 28, 2018
|
Thanks @Lyrkan! |
weaverryan
added a commit
that referenced
this pull request
Dec 13, 2018
…ath (Lyrkan) This PR was squashed before being merged into the master branch (closes #456). Discussion ---------- Display a warning when calling "copyFiles" with an invalid path This PR adds a warning when `copyFiles()` is called with a `from` value that isn't an existing directory. This is kind of related to #445 but even if the friendly-errors-webpack-plugin worked properly in this case the origin of the error would probably not be obvious (it'd most likely contain a reference to the temporary entry). Commits ------- 5161d30 Display a different warning when trying to copy from an unexisting directory or an invalid one 8cb9d4a Display a warning when calling "copyFiles" with an invalid path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning when
copyFiles()is called with afromvalue that isn't an existing directory.This is kind of related to #445 but even if the friendly-errors-webpack-plugin worked properly in this case the origin of the error would probably not be obvious (it'd most likely contain a reference to the temporary entry).