Skip to content

Commit 9e216d5

Browse files
authored
Remove NoProtectedClassElementRule as overly strict (#115)
1 parent 7b9c561 commit 9e216d5

19 files changed

+1
-508
lines changed

config/services/services.neon

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ services:
2222
- Symplify\PHPStanRules\NodeFinder\MethodCallNodeFinder
2323
- Symplify\PHPStanRules\NodeFinder\ReturnNodeFinder
2424
- Symplify\PHPStanRules\ParentClassMethodNodeResolver
25-
- Symplify\PHPStanRules\ParentGuard\ParentClassMethodGuard
26-
- Symplify\PHPStanRules\ParentGuard\ParentElementResolver\ParentMethodResolver
2725
- Symplify\PHPStanRules\PhpDoc\ApiDocStmtAnalyzer
2826
- Symplify\PHPStanRules\PhpDoc\BarePhpDocParser
2927
- Symplify\PHPStanRules\PhpDoc\PhpDocResolver

config/static-rules.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
rules:
2-
- Symplify\PHPStanRules\Rules\NoProtectedClassElementRule
32
- Symplify\PHPStanRules\Rules\ForbiddenExtendOfNonAbstractClassRule
43
- Symplify\PHPStanRules\Rules\Complexity\ForbiddenSameNamedNewInstanceRule
54

docs/rules_overview.md

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# 46 Rules Overview
1+
# 45 Rules Overview
22

33
## AnnotateRegexClassConstWithRegexLinkRule
44

@@ -926,38 +926,6 @@ final class SomeClass
926926

927927
<br>
928928

929-
## NoProtectedClassElementRule
930-
931-
Instead of protected element, use private element or contract method
932-
933-
- class: [`Symplify\PHPStanRules\Rules\NoProtectedClassElementRule`](../src/Rules/NoProtectedClassElementRule.php)
934-
935-
```php
936-
final class SomeClass
937-
{
938-
protected function run()
939-
{
940-
}
941-
}
942-
```
943-
944-
:x:
945-
946-
<br>
947-
948-
```php
949-
final class SomeClass
950-
{
951-
private function run()
952-
{
953-
}
954-
}
955-
```
956-
957-
:+1:
958-
959-
<br>
960-
961929
## NoReferenceRule
962930

963931
Use explicit return value over magic &reference

src/ParentGuard/ParentClassMethodGuard.php

Lines changed: 0 additions & 24 deletions
This file was deleted.

src/ParentGuard/ParentElementResolver/ParentMethodResolver.php

Lines changed: 0 additions & 39 deletions
This file was deleted.

src/Rules/NoProtectedClassElementRule.php

Lines changed: 0 additions & 194 deletions
This file was deleted.

tests/Rules/NoProtectedClassElementRule/Fixture/FirstClass.php

Lines changed: 0 additions & 20 deletions
This file was deleted.

tests/Rules/NoProtectedClassElementRule/Fixture/SkipAbstractTestCase.php

Lines changed: 0 additions & 14 deletions
This file was deleted.

tests/Rules/NoProtectedClassElementRule/Fixture/SkipInterface.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoProtectedClassElementRule/Fixture/SkipKernelProtectedMethod.php

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)