Skip to content

Commit a102e27

Browse files
authored
Remove NoEmptyClassRule, as rarely true and already coverd by class-leak (#124)
* Remove NoEmptyClassRule, as rarely true and already coverd by class-leak * misc
1 parent f687a20 commit a102e27

16 files changed

+0
-336
lines changed

config/static-rules.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ rules:
2727

2828
- Symplify\PHPStanRules\Rules\Complexity\ForbiddenArrayMethodCallRule
2929
- Symplify\PHPStanRules\Rules\CheckRequiredInterfaceInContractNamespaceRule
30-
- Symplify\PHPStanRules\Rules\NoEmptyClassRule
3130

3231
# naming
3332
- Symplify\PHPStanRules\Rules\RequireAttributeNameRule

docs/rules_overview.md

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -645,35 +645,6 @@ class SomeClass
645645

646646
<br>
647647

648-
## NoEmptyClassRule
649-
650-
There should be no empty class
651-
652-
- class: [`Symplify\PHPStanRules\Rules\NoEmptyClassRule`](../src/Rules/NoEmptyClassRule.php)
653-
654-
```php
655-
class SomeClass
656-
{
657-
}
658-
```
659-
660-
:x:
661-
662-
<br>
663-
664-
```php
665-
class SomeClass
666-
{
667-
public function getSome()
668-
{
669-
}
670-
}
671-
```
672-
673-
:+1:
674-
675-
<br>
676-
677648
## NoInlineStringRegexRule
678649

679650
Use local named constant instead of inline string for regex to explain meaning by constant name

src/Rules/NoEmptyClassRule.php

Lines changed: 0 additions & 136 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Fixture/SkipAttribute.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Fixture/SkipEmptyClassWithImplements.php

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Fixture/SkipException.php

Lines changed: 0 additions & 11 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Fixture/SkipFinalChildOfAbstract.php

Lines changed: 0 additions & 11 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Fixture/SkipMarkerInterface.php

Lines changed: 0 additions & 9 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Fixture/SkipWithCommentAbove.php

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Fixture/SkipWithCommentInterface.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Fixture/SkipWithContent.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Fixture/SomeEmptyClass.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/NoEmptyClassRuleTest.php

Lines changed: 0 additions & 50 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Source/AbstractAnother.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/Source/AnInterface.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/Rules/NoEmptyClassRule/config/configured_rule.neon

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)